Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Woocommerce #24

Open
danielmrey opened this issue Feb 20, 2018 · 4 comments
Open

Woocommerce #24

danielmrey opened this issue Feb 20, 2018 · 4 comments

Comments

@danielmrey
Copy link
Contributor

danielmrey commented Feb 20, 2018

Hi Simon:

I am starting to add Woocommerce functionality, I took mainly all from your WBST.

When I used your WBST I took this JS code, maybe you can compare with the one that you have in functions/boostrap-4/bootstrap-4-wp.js and maybe add some of this code on board:


        // Adding Bootstrap classes to the Comments stuff
        $(".commentlist li").addClass("panel panel-default");
        $(".comment-reply-link").addClass("btn btn-default");
  
        // Forms
        $('select, input[type=text], input[type=email], input[type=password], textarea, input[type=tel], input[type=number]').addClass('form-control');
        $('input[type=submit]').addClass('btn btn-primary');

Thanks

@danielmrey
Copy link
Contributor Author

Hi Simon:

This is in general the Woocommerce implementation:

2 Enqueues: wbst.css and wbst.js (DONE)

1 Function: woocommerce-setup.php
I am calling this in functions/woocommerce/woocommerce.php (DONE)

1 Template: woocommerce.php
I don't know where to put this file, it calls:
I think it needs to be in the root of the Theme, but I'd like to place it in woocommerce folder for encapsulation (PENDING)

Thanks

@SimonPadbury
Copy link
Member

Ensure that woocommerce.php is up to date -- not from my old theme WBST unless it is still the same.

@danielmrey
Copy link
Contributor Author

I think we do not need template as per the second way of adding Woocomemrce compatibility in this article (I think you used this in your WBST):

https://stackoverflow.com/questions/24283988/how-to-make-a-wordpress-theme-woocommerce-compatible?rq=1

@danielmrey
Copy link
Contributor Author

Just committed all the files needed for Woocommerce, when you can can you give it a look?

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants