Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash on editor exit #171

Open
muchcharles opened this issue Jul 29, 2024 · 0 comments
Open

Crash on editor exit #171

muchcharles opened this issue Jul 29, 2024 · 0 comments

Comments

@muchcharles
Copy link

muchcharles commented Jul 29, 2024

UE 5.3.2 launcher build, UEGitPlugin 3.16 release

Got a crash exiting the editor on GetModuleChecked after exiting had unloaded the plugin:

GitSourceControlUtils.cpp
bool UpdateChangelistStateByCommand()
{
    FGitSourceControlModule& GitSourceControl = FModuleManager::GetModuleChecked<FGitSourceControlModule>("GitSourceControl");

callstack:

Assertion failed: ModuleManager.IsModuleLoaded(ModuleName) [File:G:\EpicGames\UE_5.3\Engine\Source\Runtime\Core\Public\Modules\ModuleManager.h] [Line: 309] Tried to get module interface for unloaded module: 'GitSourceControl'

UnrealEditor_GitSourceControl!GitSourceControlUtils::UpdateChangelistStateByCommand() [C:\projroot\projectroot2\project\Plugins\UEGitPlugin\Source\GitSourceControl\Private\GitSourceControlUtils.cpp:1635]
UnrealEditor_GitSourceControl!GitSourceControlUtils::RunUpdateStatus() [C:\projroot\projectroot2\project\Plugins\UEGitPlugin\Source\GitSourceControl\Private\GitSourceControlUtils.cpp:1709]
UnrealEditor_GitSourceControl!FGitFetchWorker::Execute() [C:\projroot\projectroot2\project\Plugins\UEGitPlugin\Source\GitSourceControl\Private\GitSourceControlOperations.cpp:690]
UnrealEditor_GitSourceControl!FGitSourceControlCommand::DoThreadedWork() [C:\projroot\projectroot2\project\Plugins\UEGitPlugin\Source\GitSourceControl\Private\GitSourceControlCommand.cpp:52]
UnrealEditor_Core!FQueuedThreadPoolWrapper::FScheduledWork::DoThreadedWork() [D:\build\++UE5\Sync\Engine\Source\Runtime\Core\Public\Misc\QueuedThreadPoolWrapper.h:141]
UnrealEditor!`LowLevelTasks::FTask::Init<`FQueuedLowLevelThreadPool::AddQueuedWork'::`2'::<lambda_1> >'::`11'::<lambda_1>::operator()() [D:\build\++UE5\Sync\Engine\Source\Runtime\Core\Public\Async\Fundamental\Task.h:499]
UnrealEditor!LowLevelTasks::TTaskDelegate<LowLevelTasks::FTask * __cdecl(bool),48>::TTaskDelegateImpl<`LowLevelTasks::FTask::Init<`FQueuedLowLevelThreadPool::AddQueuedWork'::`2'::<lambda_1> >'::`11'::<lambda_1>,0>::CallAndMove() [D:\build\++UE5\Sync\Engine\Source\Runtime\Core\Public\Async\Fundamental\TaskDelegate.h:171]
UnrealEditor_Core!LowLevelTasks::FTask::ExecuteTask() [D:\build\++UE5\Sync\Engine\Source\Runtime\Core\Public\Async\Fundamental\Task.h:627]
UnrealEditor_Core!LowLevelTasks::FScheduler::ExecuteTask() [D:\build\++UE5\Sync\Engine\Source\Runtime\Core\Private\Async\Fundamental\Scheduler.cpp:172]
UnrealEditor_Core!LowLevelTasks::FScheduler::TryExecuteTaskFrom<LowLevelTasks::TLocalQueueRegistry<1024>::TLocalQueue,&LowLevelTasks::TLocalQueueRegistry<1024>::TLocalQueue::DequeueGlobal,0>() [D:\build\++UE5\Sync\Engine\Source\Runtime\Core\Private\Async\Fundamental\Scheduler.cpp:350]
UnrealEditor_Core!LowLevelTasks::FScheduler::WorkerMain() [D:\build\++UE5\Sync\Engine\Source\Runtime\Core\Private\Async\Fundamental\Scheduler.cpp:378]
UnrealEditor_Core!UE::Core::Private::Function::TFunctionRefCaller<`LowLevelTasks::FScheduler::CreateWorker'::`2'::<lambda_1>,void __cdecl(void)>::Call() [D:\build\++UE5\Sync\Engine\Source\Runtime\Core\Public\Templates\Function.h:480]
UnrealEditor_Core!FThreadImpl::Run() [D:\build\++UE5\Sync\Engine\Source\Runtime\Core\Private\HAL\Thread.cpp:69]
UnrealEditor_Core!FRunnableThreadWin::Run() [D:\build\++UE5\Sync\Engine\Source\Runtime\Core\Private\Windows\WindowsRunnableThread.cpp:149]
mastercoms added a commit that referenced this issue Aug 7, 2024
Fix thread crash on editor exit due to module unavailability #171
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant