Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Godot Method Names Not Ported Correctly #4

Closed
bshikin opened this issue Sep 18, 2023 · 3 comments · Fixed by #47
Closed

Godot Method Names Not Ported Correctly #4

bshikin opened this issue Sep 18, 2023 · 3 comments · Fixed by #47
Labels
prompt ChatGPT prompt change

Comments

@bshikin
Copy link
Contributor

bshikin commented Sep 18, 2023

  • It looks like Start() method is being ported at _on_start(), but it should be _ready()
  • OnEnable() should be _enter_tree() I think

We need to look at Godot system prompt to and experiment with listing those as translation rules
@bshikin bshikin added the prompt ChatGPT prompt change label Sep 18, 2023
@a2937
Copy link

a2937 commented Sep 20, 2023

Yes, OnEnable() can become _enter_tree. I'm not quite sure how to get started assisting though

@thomasmso thomasmso changed the title Godot Method Names No Ported Correctly Godot Method Names Not Ported Correctly Sep 20, 2023
@bshikin bshikin linked a pull request Sep 21, 2023 that will close this issue
Use RAG LLM Trick to Support Known Translations #47
Merged
@bshikin
Copy link
Contributor Author

bshikin commented Sep 21, 2023

Note: this issue will be addressed by #47

@bshikin
Copy link
Contributor Author

bshikin commented Sep 21, 2023

Fix has been merged into master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
prompt ChatGPT prompt change
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use RAG LLM Trick to Support Known Translations ProjectUnifree/unifree
2 participants
@bshikin @a2937