Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Unit Tests] Better test for code_extrators::extract_header_implementation #9

Open
bshikin opened this issue Sep 18, 2023 · 1 comment
Labels
good first issue Good for newcomers unittest Unit test improvement

Comments

@bshikin
Copy link
Contributor

bshikin commented Sep 18, 2023

ChatGptMixin::extract_header_implementation doesn't test a case when ChatGPT doesn't split header/implementation at all

@bshikin bshikin added good first issue Good for newcomers unittest Unit test improvement labels Sep 18, 2023
@bshikin bshikin changed the title Test Coverage: ChatGptMixin::extract_header_implementation [Unit Tests] Better test for code_extrators::extract_header_implementation Sep 21, 2023
@just-in-chang
Copy link

just-in-chang commented Sep 22, 2023

@bshikin I can take this! By not splitting the header/implementations, do you mean like this (same code block):

// Header.h
{header code}

// Implementation.cpp
{implementation code}

or this (no comments)?

{header code}
{implementation code}

If the latter, what is the intended behavior? should all of the code just be returned in the header?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers unittest Unit test improvement
Projects
None yet
Development

No branches or pull requests

2 participants