-
Notifications
You must be signed in to change notification settings - Fork 658
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Arrays. #2888
[Feature] Arrays. #2888
Conversation
Codecov Report
@@ Coverage Diff @@
## testnet3 #2888 +/- ##
============================================
+ Coverage 78.90% 79.24% +0.34%
============================================
Files 164 172 +8
Lines 5522 5791 +269
Branches 5522 5791 +269
============================================
+ Hits 4357 4589 +232
- Misses 1165 1202 +37
... and 9 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me, modulo a comment I left, but I'm not super-familiar with certain parts of the code yet. I'm also happy to take another look when more documentation is added — you can just re-request a review.
b6851a9
to
116d83b
Compare
This PR:
TypeTable
, which tracks the types of expressions across the AST passes.Arrays
[a, b, c, d]
Let's look at some example code.
This function takes in an array as input and returns the sum of its elements.
Note that array types can be declared as
[<element_type>; <nonzero_number>]