Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fully dockerize the build #380

Open
Kamel-83 opened this issue Oct 13, 2023 · 3 comments
Open

Fully dockerize the build #380

Kamel-83 opened this issue Oct 13, 2023 · 3 comments
Labels
deployment Issues that update Docker or Makefiles

Comments

@Kamel-83
Copy link

Kamel-83 commented Oct 13, 2023

There is some issues with the docker containers of core\ui projects and so the project already has some Dockerfile https://github.com/ProxeusApp/proxeus-core/blob/main/Dockerfile and there is some instruction for the end users how to setup their environments using Docker https://doc.proxeus.org/#/build_docker?id=using-docker-during-development

[Dockerfile](https://github.com/ProxeusApp/proxeus-core/blob/main/Dockerfile)
FROM debian:stable-slim

RUN apt-get update && apt-get install -y \
        ca-certificates \
    && apt-get clean && rm -rf /var/cache/* /var/lib/apt/lists/*

it's not how it supposed to be implemented using Docker. this implementation is fully dependents on the CircleCI environments, so you can't actually run it locally with you docker. because if you try (using that docker-compose file) you will automatically use prebuilt proxeus image, not your one’s
and you can't [docker build] it locally, you have to [make all] it first. and don't forget to setup the correct environment on your PC before
if we're talking about Docker - all this magic should be inside (some) Dockerfile-[server/ui/etc]. so I'm writing to let you know about this potential task. we can do it if you agreed, but it may take some extra time, of course.

@Kamel-83 Kamel-83 converted this from a draft issue Oct 13, 2023
@Kamel-83 Kamel-83 moved this from Todo to Agreed for Dev in Maintenance - Q1 2024 Oct 13, 2023
@loleg
Copy link
Contributor

loleg commented Oct 13, 2023

@slavas490 if it continues to be troubling to set up with the current (I agree rather messy Makefile) setup, then we can come back to this.

@loleg loleg changed the title Dockerize proxeus Fully dockerize the build Oct 13, 2023
@loleg loleg moved this from Agreed for Dev to Todo in Maintenance - Q1 2024 Oct 13, 2023
@loleg
Copy link
Contributor

loleg commented Nov 16, 2023

As noted in #411 it is currently not possible to complete the build fully on Docker.

@loleg loleg added the deployment Issues that update Docker or Makefiles label Nov 16, 2023
@loleg
Copy link
Contributor

loleg commented Jan 22, 2024

One thing to add here: we should switch to https://github.com/docker/buildx#buildx (I keep seeing warnings in the CI).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployment Issues that update Docker or Makefiles
Projects
Development

No branches or pull requests

3 participants