-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fully dockerize the build #380
Labels
deployment
Issues that update Docker or Makefiles
Comments
@slavas490 if it continues to be troubling to set up with the current (I agree rather messy Makefile) setup, then we can come back to this. |
As noted in #411 it is currently not possible to complete the build fully on Docker. |
One thing to add here: we should switch to https://github.com/docker/buildx#buildx (I keep seeing warnings in the CI). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
There is some issues with the docker containers of core\ui projects and so the project already has some Dockerfile https://github.com/ProxeusApp/proxeus-core/blob/main/Dockerfile and there is some instruction for the end users how to setup their environments using Docker https://doc.proxeus.org/#/build_docker?id=using-docker-during-development
it's not how it supposed to be implemented using Docker. this implementation is fully dependents on the CircleCI environments, so you can't actually run it locally with you docker. because if you try (using that docker-compose file) you will automatically use prebuilt proxeus image, not your one’s
and you can't [docker build] it locally, you have to [make all] it first. and don't forget to setup the correct environment on your PC before
if we're talking about Docker - all this magic should be inside (some) Dockerfile-[server/ui/etc]. so I'm writing to let you know about this potential task. we can do it if you agreed, but it may take some extra time, of course.
The text was updated successfully, but these errors were encountered: