refactor(Rune): drop halves-group container for two-color chars #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See robertabcd/PttChrome#102 for references. * src/components/cells/Rune.tsx * drop the use of CSS class .halves-group * use react.Fragment (`<> </>`) to replace the previous outer `<span>` * make classNamesGroup (for styling the previous outer `<span>`) appended to classNames0 (for styling each two-color char) * src/components/cells/ContentRenderer.module.css * drop CSS class .halves-group * replace .halves styling with .o styling from the PttChrome PR
|
(deployed as 0.14.5) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The two-color-word effect, before and after this change. They should look the same despite the difference of HTML layout.
Why
By the PR of PttChrome mentioned below, it is known that two-color characters are possible without using an outer
<span>.How
src/components/cells/Rune.tsx.halves-groupreact.Fragment(<> </>) to replace the previous outer<span>classNamesGroup(for styling the previous outer<span>) appended toclassNames0(for styling each two-color char)src/components/cells/ContentRenderer.module.css.halves-group.halvesstyling with.ostyling from the PttChrome PRRelated Issues
#122, where the support of two-color character display has been introduced.
References
robertabcd/PttChrome#102