Skip to content
This repository has been archived by the owner on Jun 3, 2021. It is now read-only.

Reorganization/update of the repo #5

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

celianvdb
Copy link

No description provided.

@celianvdb celianvdb marked this pull request as ready for review April 21, 2020 00:01
@Daimonion1980
Copy link

Daimonion1980 commented May 3, 2020

Hey, @celianvdb. Thanks for your work.
Yesterday i managed to user your pull request to setup the whole serversystem. Great work so far.

Just one point i got rid of. sftp generates a new key every startup.

To prevent this i generated the keys before start and modified the docker-compose file to use generated keys.
For generation i used the commands atmoz/sftp documented on its site:
https://hub.docker.com/r/atmoz/sftp/ chapter "Providing your own SSH host key (recommended)"

And second thing: I changed docker-compose file in section sftp-->volumes to:

volumes: - maniaplanet:/home/maniaplanet/dedicated - pyplanet:/home/maniaplanet/pyplanet - ./ssh_keys/ssh_host_ed25519_key:/etc/ssh/ssh_host_ed25519_key - ./ssh_keys/ssh_host_rsa_key:/etc/ssh/ssh_host_rsa_key

Generated a subfolder in the folder where the docker-compose lays
Maybe you can manage it that sftp can generate the kyes on its own and store it persistently.

@celianvdb
Copy link
Author

Hi, thank you ! You right, that's something I need to improve ! I think that I will just create a volume with the host key so it will not be generate it again every time the container is recreated. I will try to push that tonight or tomorrow ;)

@celianvdb
Copy link
Author

celianvdb commented May 15, 2020

Looks like I forgot ... Sorry, since docker still doesn't support to mount subdfolder/specific file of named volume I think that your fix is the best one for now. I will add that tomorrow.

@celianvdb
Copy link
Author

Done @Daimonion1980 ! Thx for your help :)

@tomvlk I think that this pull request is ready to merge.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants