Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve the NL writer #1151

Closed
carldlaird opened this issue Nov 5, 2019 · 3 comments
Closed

Improve the NL writer #1151

carldlaird opened this issue Nov 5, 2019 · 3 comments
Labels
performance

Comments

@carldlaird
Copy link
Member

carldlaird commented Nov 5, 2019 •
edited by blnicho
Loading

Improve the performance of the NL writer - several suggestions have been proposed:

  1. profile and see if there is low hanging fruit
  2. look at implementing a binary NL format
  3. look at implementing a C-based writer

Still need to gather data on these options to see which has the most promise.
@carldlaird carldlaird changed the title Performance Suggestion Improve the NL writer Nov 5, 2019
@whart222
Copy link
Member

whart222 commented Nov 7, 2019

I think we should call these out as separate activities.

@whart222
Copy link
Member

whart222 commented Nov 7, 2019

Should we close this?

Option (2) is redundant with #177 .
Option (3) is redundant with #1158

@whart222 whart222 mentioned this issue Nov 19, 2019
Closed
@jsiirola jsiirola mentioned this issue May 8, 2020
Closed
@jsiirola
Copy link
Member

jsiirola commented May 8, 2020

Archived on the master Performance Proposals Issue (#1430). Closing this performance proposal until active development has begun.

@jsiirola jsiirola closed this as completed May 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
performance
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jsiirola @whart222 @carldlaird