Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] testParseSingleBdNameAndTableNameWithError in tableNameCollectorTest is not as expected #280

Open
IcePigZDB opened this issue Jul 11, 2022 · 0 comments · May be fixed by #279
Open

[BUG] testParseSingleBdNameAndTableNameWithError in tableNameCollectorTest is not as expected #280

IcePigZDB opened this issue Jul 11, 2022 · 0 comments · May be fixed by #279

Comments

@IcePigZDB
Copy link

IcePigZDB commented Jul 11, 2022 •
edited
Loading

Versions

eg: 99b77fb

Describe the bug

Current error parameter in validateTableName can not throw exception in case of A.A.A, see testParseSingleBdNameAndTableNameWithError and testParseSingleBdNameAndTableNameWithError2.

To Reproduce

Steps to reproduce the behavior:

  1. Go to TableNameCollectorTest
  2. Dubug on testParseSingleBdNameAndTableNameWithError
  3. You will find no exception throw, I think it's not as expected.

Expected behavior

Throw exception.

Actual behavior

No exception. Because there is no exception, so it pass these two tests luckily.

Additional context

截图_选择区域_20220711121158
@IcePigZDB IcePigZDB changed the title testParseSingleBdNameAndTableNameWithError in tableNameCollectorTest is not correct [BUG] testParseSingleBdNameAndTableNameWithError in tableNameCollectorTest is not correct Jul 11, 2022
@IcePigZDB IcePigZDB linked a pull request Jul 11, 2022 that will close this issue
Open
10 tasks
@IcePigZDB IcePigZDB changed the title [BUG] testParseSingleBdNameAndTableNameWithError in tableNameCollectorTest is not correct [BUG] testParseSingleBdNameAndTableNameWithError in tableNameCollectorTest is not as expected Jul 11, 2022
IcePigZDB pushed a commit to IcePigZDB/Quicksql that referenced this issue Jul 11, 2022
fix: update error parameter from 3 to 2 in tableNameCollector in case of
be16932 
ref: Qihoo360#280
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: update error parameter from 3 to 2 in tableNameCollector in case of A.A.A IcePigZDB/Quicksql
1 participant
@IcePigZDB