Update macOS x86_64 wheel build CI runner to 10.13 #13470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Github actions has deprecated their macOS 10.12 CI runner and will be removing it in December, 2024. We were using this macOS runner because our target OS version for intel mac is 10.12. However, with this enviornment being removed by Github we must upgrade to continue running the jobs. This commit does not bump the MACOSX_DEPLOYMENT_TARGET environment variable (which is used to set the target OS version for intel macs) though, because we should test if we can build it compatibility mode from a newer version of macOS. If this fails then we can bump this to 10.13 in a subsequent commit on this PR and add an upgrade release note to document the change.
mtreinish
added
on hold
|
One or more of the following people are relevant to this code:
|
|
It's actually macOS 13, not 10.13 - they left the OSX numbering behind with the release of macOS 11 for Apple silicon. |
jakelishman
approved these changes
Nov 20, 2024
Pull Request Test Coverage Report for Build 11943215073Details
💛 - Coveralls |
|
Oh, I think you might have made a mistake in your reasoning in the top comment - the macOS 12 OS is already way newer (Monterey, released 2021) than the 10.12 minimum version (Sierra, released 2016) we target. We still used macOS 12 in the wheel builds only because you made the minimal bump for GHA while I made the maximal stable bump for Azure (#12882 vs #12571). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Github actions has deprecated their macOS 10.12 CI runner and will be removing it in December, 2024. We were using this macOS runner because our target OS version for intel mac is 10.12. However, with this enviornment being removed by Github we must upgrade to continue running the jobs.
This commit does not bump the MACOSX_DEPLOYMENT_TARGET environment variable (which is used to set the target OS version for intel macs) though, because we should test if we can build it compatibility mode from a newer version of macOS. If this fails then we can bump this to 10.13 in a subsequent commit on this PR and add an upgrade release note to document the change.
Details and comments