-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adaptive step-size Commutator free exponential solver (ACFET) #588
Open
kaihsin
wants to merge
39
commits into
master
Choose a base branch
from
khwu/adapt_cfet
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1) moving Hamiltonian/StepHamiltonian and ThreadedMatrix to Operator module 2) moving all linalg associate to 1) are moving to Operator module.
1) move linalg related to elementary structs (PermMatrix,Diagonal,SparseMatrixCSR/CSC) to Lowlevel/backends/ 2) rename module Operator -> Lowlevel to avoid confusion with Yao 3) rename test/linalg.jl to test/linalg_mul.jl 4) [FIX] mul! testing case for ParallelMergeCSR is not properly dispatched. 5) add trace() and bind to LinearAlgebra.tr() for PermMatrix,Diagonal and SparseMatrixCSR/CSC 6) add test/linalg_tr.jl for testing tr()
1) add precision_type() for Hamiltonian/StepHamiltonian 2) add highest_type() for Hamiltonian/StepHamiltonian
2) move linalg associate to Hamiltonian etc to linalg.jl
1) Remove StepHamiltonian 2) Rename ValHamiltonian -> SumOfLinop
1) Add expm_multiply, tested but this version consume more memory 2) Add get_optimal_sm() to get the optimal s and m_star. currently the one norm of power p is get exactly, not estimate (need to implement one norm est !
1) add onenormest() using block algorithm for 1 norm estimation
1) swap out the onenorm in expm_multiply using onenormest() 2) reinstat all the testing cases. 3) checking testing of expm_multiply
…nian 2) change test, linalg, size, types related to accomadate change.
… of AbstractMatrix. 2) modify parts to accompany change of SumOfLinop
1) additional field types for SumOfLinop Hermitian, SkewHermitian and RegularLinop 2) adjoint, Base.:*, add_I for lazy evaluate in the case input is Hermitian/SkewHermitian
1) this is dirty version. need to be clean 2) fix the bug in calculating h in onenormest
1) fix bug in precision_type/highest_type/eltype for SumOfLinop by considering also dtype of fvals 2) add testing case for expm_multiply backend 3) add expmv_backend as additional options, and update docstring. 4) fix bug in get_optimal_sm when t is negative.
1) add FowardDiff in BloqadeExpr 2) add derivative(H,t) for calculating Hamiltonian H'(t) 3) add testing case
…into khwu/expm_multiply
…g/Bloqade.jl into khwu/expm_multiply
* Refactor Expr 1) moving Hamiltonian/StepHamiltonian and ThreadedMatrix to Operator module 2) moving all linalg associate to 1) are moving to Operator module. * BloqadeExpr Change 1) move linalg related to elementary structs (PermMatrix,Diagonal,SparseMatrixCSR/CSC) to Lowlevel/backends/ 2) rename module Operator -> Lowlevel to avoid confusion with Yao 3) rename test/linalg.jl to test/linalg_mul.jl 4) [FIX] mul! testing case for ParallelMergeCSR is not properly dispatched. 5) add trace() and bind to LinearAlgebra.tr() for PermMatrix,Diagonal and SparseMatrixCSR/CSC 6) add test/linalg_tr.jl for testing tr() * Get types info on Hamiltonain 1) add precision_type() for Hamiltonian/StepHamiltonian 2) add highest_type() for Hamiltonian/StepHamiltonian * add overload for SparseMatrixCSR, and remove redundant print * Move ValHamiltionain from BloqadeKrylov to BloqadeExpr.Lowlevel * 1) Add more testing cases for ValHamiltonian 2) move linalg associate to Hamiltonian etc to linalg.jl * fix ASCII for '-' causing error on julia-v1.6 * Simplify Lowlevel data structure 1) Remove StepHamiltonian 2) Rename ValHamiltonian -> SumOfLinop * 1) remove BloqadeKrylov from toml 2) remove redundant comments --------- Co-authored-by: Kai-Hsin Wu <[email protected]> Co-authored-by: Kai-Hsin Wu <[email protected]>
1) move all derivative of Hamiltonian under ForwardDiff 2) finalize ACFETEvolution interface, which under abstract type ADEvolution (ADaptive Evolution) 3) finish and tested Adaptive step size CFET for CFET2_1
1) fix bug in calculating local error (missing t/(p+1) before) 2) add CFET4_2 options, and the corresponding test
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #588 +/- ##
==========================================
- Coverage 77.30% 77.28% -0.02%
==========================================
Files 93 93
Lines 4609 4610 +1
==========================================
Hits 3563 3563
- Misses 1046 1047 +1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is branching from PR #585, which includes adaptive step-size generalization of the existing CFET solver.