Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Code] Do we really need Utils::Bitset? #157

Open
rturrado opened this issue Jun 18, 2024 · 0 comments
Open

[Code] Do we really need Utils::Bitset? #157

rturrado opened this issue Jun 18, 2024 · 0 comments

Comments

@rturrado
Copy link
Contributor

Utils::Bitset may be a bit faster than std::bitset, but I don't see that's strong enough a reason to have this code.
We could use boost::dynamic_bitset, as we are already doing for BitRegisterMeasurement.
So a BasisVector would become a boost::dynamic_bitset<uint8_t>.
The fact that we could define these basis vectors with dynamic size could avoid doing some substring work (in order to reduce from the static 64-bit basis vector, the biggest allowed, to the n-bit basis vector, the one managed by a QuantumState).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant