Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Infra] Enable ASAN for GitHub Actions Linux/x64 builds. #22

Open
rturrado opened this issue Mar 19, 2024 · 1 comment
Open

[Infra] Enable ASAN for GitHub Actions Linux/x64 builds. #22

rturrado opened this issue Mar 19, 2024 · 1 comment

Comments

@rturrado
Copy link
Contributor

I am going to disable it temporarily because it is making GitHub Actions fail but, at the same time, I cannot reproduce the issue locally.

However, I have a possible hint on the source of the problems: I think it has to do with libc++, ABI compatibility breakages, and small string optimization. Why?

  • I've seen tests run OK for clang/Debug, but fail for clang/Release (small string optimization may hit here).
  • I'm pretty sure small string optimizations accross compilers are linked to ABI compatibility breakages.
  • And I think there's some darkness regarding gtest and libc++.
  • The tests failing were format_utils tests, where we work with small strings.
  • If we don't compile tests, GitHub doesn't complain.
  • If we don't compile with ASAN, GitHub doesn't complain.

Tests built with Clang, c++11, and libc++ fail to link?
Trouble building tests with Google Test, Clang, and libc++

@rturrado
Copy link
Contributor Author

See QuTech-Delft/libqasm#203.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

1 participant