Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent indicator property types #8378

Open
superichmann opened this issue Oct 21, 2024 · 2 comments
Open

Inconsistent indicator property types #8378

superichmann opened this issue Oct 21, 2024 · 2 comments

Comments

@superichmann
Copy link

Most indicator properties are of IndicatorBase<IBaseDataBar> or IndicatorBase<IndicatorDataPoint> type, such as PercentB for BB.
It would be nice if all properties of all indicators would be consistent and constructed in the same manner.
For example, the PeriodsSinceMaximum property of Maximum is an INT and not one of the mentioned data types.
This makes it impossible to access past values of PeriodsSinceMaximum without implementing it myself.
Many other indicator properties are missing the window function.

@Martin-Molinero
Copy link
Member

Currently the built in window indicator functionality only applies to the Current property. Keeping this issue open so we could potentially expand it generically for all indicator properties

@superichmann
Copy link
Author

@Martin-Molinero mmm no its not, its vastly used as in PercentB. ;]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants