Improve DeepLinking by accessing the stored value of @Published properties directly #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| fileprivate func values<Value>(_ compactMap: (Any) -> Value?) -> [Value] { | ||
| children.compactMap { compactMap($0.value) } | ||
| + (superclassMirror?.values(compactMap) ?? []) |
There was a problem hiding this comment.
Let's rename the compactMap closure as it's not a compact map, it's the function that is applied by compact map (but not only!).
Suggestion: mappingFunction or transform.
(I know this code was just moved, but I only noticed it now.)
Also, this is a good example where more code is easier to read:
func values<Value>(_ mappingFunction: (Any) -> Value?) -> [Value] {
let values = children.compactMap { mappingFunction($0.value) }
if let superClassValues = superclassMirror?.values(mappingFunction) {
return values + superClassValues
} else {
return values
}
}
This makes it much more visible when recursion occurs and which is the recursion anchor.
There was a problem hiding this comment.
(Also not sure about the function name values but I see where it comes from and I don't have a better idea right now.)
|
|
||
| public var content: Any { | ||
| guard let value = Mirror(reflecting: self).descendant("storage", "value") else { | ||
| assertionFailure("We could not extract a wrappedValue from a Published property wrapper.") |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.