Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: replace empty functions with noopQrl #6871

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

wmertens
Copy link
Member

@wmertens wmertens commented Sep 8, 2024

This is a fairly trivial improvement, but it does avoid loading empty functions on the client.

To make it work, I needed to run the simplification twice (before and after segmentation) but it's still fast.

TODO:

  • make the qrl serialization skip client noopQrl

@wmertens wmertens added COMP: performance This issue is related to a performance problem or bug COMP: optimizer labels Sep 8, 2024
@wmertens wmertens self-assigned this Sep 8, 2024
@wmertens wmertens requested a review from a team as a code owner September 8, 2024 10:20
Copy link

changeset-bot bot commented Sep 8, 2024

⚠️ No Changeset found

Latest commit: f80f6be

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@wmertens
Copy link
Member Author

wmertens commented Sep 8, 2024

hmm the e2e aren't happy :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
COMP: optimizer COMP: performance This issue is related to a performance problem or bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant