Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review pilot2-submission-to-fda #46

Open
lengning opened this issue Sep 28, 2022 · 2 comments
Open

Review pilot2-submission-to-fda #46

lengning opened this issue Sep 28, 2022 · 2 comments
Labels
help wanted Extra attention is needed

Comments

@lengning
Copy link
Collaborator

lengning commented Sep 28, 2022

clone https://github.com/RConsortium/submissions-pilot2-to-fda

follow appendix of adrg

test whether the shiny app can be deployed locally

@lengning
Copy link
Collaborator Author

Thanks a lot @rpodcast for the great work! I was able to launch the shiny app following adrg

I made some minor changes in the adrg

  • changed the phuse bitbucket link (deprecated) to the phuse github link
  • session numbers (appendix 1 was numbered as 8.x)
  • updated appendix2 section title
  • added install = TRUE in
    pkglite::unpack( input = "C:/pilot2/m5/datasets/rconsortiumpilot2/analysis/adam/programs/r1pkg.txt", output = "C:/pilot2_files", install = TRUE )

I was not able to render the adrg pdf yet though as I am having troubles with the font package. will try rendering later today

@lengning lengning added the help wanted Extra attention is needed label Sep 29, 2022
@elong0527
Copy link
Collaborator

elong0527 commented Oct 1, 2022

I start to review submission content. There are few gaps for me to rerun the shiny app.

Two issues that stop me from running the shiny app on a fresh RStudio Cloud session.

Following the step teal and teal.data can not be installed. Suggest to include all github R package into the r1pkg.txt.
Following the step pilot2wrappers::set_data_path can not be find because the package is not installed. Suggest to set install=TRUE while running pkglite::unpack.

For cover letter and ADRG please refer suggestions in attached document.

cover-letter.pdf
adrg.pdf

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants