Fix update install scripts #600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have added the docker build as a check here to see if it is reasonable to build it every time a commit is made in a PR towards dev. |
Robert108
requested review from
victorjarlow,
samuelthoren and
SebastianSvanland
and removed request for
victorjarlow
samuelthoren
approved these changes
Oct 10, 2023
| @@ -3,6 +3,8 @@ name: Docker Image CI | |||
| on: | |||
| push: | |||
| branches: [ "dev*" ] | |||
| pull_request: | |||
| branches: [ "dev" ] | |||
There was a problem hiding this comment.
Should we add the master branch here too?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR uses the install scripts inside the Dockerfile which both deletes repeated code and creates a quick way of validating the install scripts since they now will be executed every time the docker image is build.
It also splits the install script into two to make use of the Docker image layer caching.
A new user entry point script is created in the root folder called setup_atos.sh