Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NullPointerException happening on RecordsFactory.getRecords() #247

Open
enriquedelpino opened this issue Nov 22, 2024 · 1 comment
Open
Labels
bug Something isn't working

Comments

@enriquedelpino
Copy link

enriquedelpino commented Nov 22, 2024

On RecordsFactory, within the method "getRecords", there is a check to see if the given reference formulation found in the mapping file is actually supported by the mapper. In the case of a non-supported reference formulation found, the code logs an error and leaves the execution run without returning from the method or throwing a controlled error.

// Select the Record Factory based on the reference formulation. 
if (!referenceFormulationRecordFactoryMap.containsKey(referenceFormulation)) { 
logger.error("Referenceformulation {} is unsupported!", referenceFormulation); 
}
ReferenceFormulationRecordFactory factory = referenceFormulationRecordFactoryMap.get(referenceFormulation); 
records = factory.getRecords(access, logicalSource, rmlStore);

Instead what happens is a factory is tried to be retrieved and use this reference, which leads to a NullPointerExcepcion that in turn gets propagated all the way up the Executor class. This happens between lines 138 and 142 of the class RecordsFactory. I have verified this error is still present on the development branch.

@DylanVanAssche
Copy link
Contributor

Thanks for spotting this, we will look into this.

@DylanVanAssche DylanVanAssche added the bug Something isn't working label Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants