Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Issue]: ROCm include path not set #172

Open
tpkessler opened this issue Oct 1, 2024 · 0 comments · May be fixed by #185
Open

[Issue]: ROCm include path not set #172

tpkessler opened this issue Oct 1, 2024 · 0 comments · May be fixed by #185
Labels
hipcc Related to HIPCC

Comments

@tpkessler
Copy link

Problem Description

Hi! I'm packaging ROCm for Arch Linux and having issues with ROCm include paths in recent releases of ROCm.

ROCm include paths in /opt/rocm/include are not passed to hipcc in ROCm 6.2.x. The flag -I /opt/rocm/include does appear in the output of hipconfig, see below. Functions like getHipInclude() and getHipPath() are called multiple times in hipBin_amd.h but their return value is only used for output to stdout. For the nvidia wrapper in hipBin_nvidia.h, the CUDA and ROCm paths are appended to hipCFlags and hipCXXFlags.

Operating System

Arch Linux

CPU

AMD Ryzen 7 7840HS with Radeon 780M Graphics

GPU

AMD Radeon VII

ROCm Version

ROCm 6.2.0

ROCm Component

HIPCC

Steps to Reproduce

echo "#include <hip/hip_runtime.h>" | /opt/rocm/bin/hipcc -E -

(Optional for Linux users) Output of /opt/rocm/bin/rocminfo --support

No response

Additional Information

HIP version: 6.2.41134-0

==hipconfig
HIP_PATH           :/opt/rocm
ROCM_PATH          :/opt/rocm
HIP_COMPILER       :clang
HIP_PLATFORM       :amd
HIP_RUNTIME        :rocclr
CPP_CONFIG         : -D__HIP_PLATFORM_HCC__= -D__HIP_PLATFORM_AMD__= -I/opt/rocm/include -I/include

==hip-clang
HIP_CLANG_PATH     :/opt/rocm/lib/llvm/bin
clang version 18.0.0git (/srcdest/rocm-llvm 77cf9ad00e298ed06e06aec0f81009510f545714)
Target: x86_64-pc-linux-gnu
Thread model: posix
InstalledDir: /opt/rocm/lib/llvm/bin
AOMP-18.0-12 (http://github.com/ROCm-Developer-Tools/aomp):
 Source ID:18.0-12-ce1873ac686bb90ddec72bb99889a4e80e2de382
  LLVM version 18.0.0git
  Optimized build with assertions.
  Default target: x86_64-pc-linux-gnu
  Host CPU: znver4

  Registered Targets:
    amdgcn  - AMD GCN GPUs
    nvptx   - NVIDIA PTX 32-bit
    nvptx64 - NVIDIA PTX 64-bit
    r600    - AMD GPUs HD2XXX-HD6XXX
    x86     - 32-bit X86: Pentium-Pro and above
    x86-64  - 64-bit X86: EM64T and AMD64
hip-clang-cxxflags :
 -O3
hip-clang-ldflags :
--driver-mode=g++ -O3 --hip-link
@tpkessler tpkessler changed the title [Issue]: [HIPCC]: ROCm include path not set Oct 1, 2024
@tpkessler tpkessler changed the title [HIPCC]: ROCm include path not set [Issue]: ROCm include path not set Oct 1, 2024
@lamb-j lamb-j added the hipcc Related to HIPCC label Oct 1, 2024
@tpkessler tpkessler linked a pull request Oct 13, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
hipcc Related to HIPCC
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[hipcc] Populate compiler and linker flags on AMD platform tpkessler/llvm-project
2 participants
@lamb-j @tpkessler