Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add WebRTC Signalling server logic #9

Open
cwisniew opened this issue Sep 5, 2021 · 3 comments
Open

Add WebRTC Signalling server logic #9

cwisniew opened this issue Sep 5, 2021 · 3 comments
Assignees
Labels

Comments

@cwisniew
Copy link
Member

cwisniew commented Sep 5, 2021

Is your feature request related to a problem? Please describe.
Add signalling server logic to the server registry to support RPTools/maptool#2876

Describe the solution you'd like
When the pilot/beta phase of the WebRTC connection for MapTool is completed the signalling server logic will need to be rolled into the registry.

@thelsing
Copy link

I think we should also store a server type in the server registry. The player connecting to a server shouldn't have to know if he has to use WebRTC or not. This information should come from the registry. Anticipating more server types in the future it should be an enum an not a IsWebRTC bool IMO.

@cwisniew
Copy link
Member Author

I think we should also store a server type in the server registry. The player connecting to a server shouldn't have to know if he has to use WebRTC or not. This information should come from the registry. Anticipating more server types in the future it should be an enum an not a IsWebRTC bool IMO.

I agree, at the moment the server registry is completely unaware this is going on but when when we add the WebRTC signalling support to it then we can remove the use WebRTC checkbox from the connect to server dialog and have the client retrieve that information from the registry.

@thelsing
Copy link

thelsing commented Jan 15, 2022

We probably also need a TURN server for webRTC. TURN-servers require authentication. I think it would be a bad idea to put credentials for our TURN server in the source code because other people will probably use up our traffic.

coturn can be configured to use a mysql backend. How about we add the coturn tables to our db and add secrets an allowed ips for users during the signaling process.

So it would work like:
sequence diagram

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants