Webrtc improvements #3789
Merged
Webrtc improvements #3789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/main/resources/net/rptools/maptool/client/ui/forms/connectToServerDialog.xml
|
I noticed some issues when a server or player already exists. I will fix those too. So don't merge this yet. |
|
Ok. My issues aren't related to webrtc. Will do an additional PR when I'm done with them. So this PR is ready to merge from my side. |
Phergus
approved these changes
Dec 27, 2022
There was a problem hiding this comment.
Reviewed 16 of 16 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @thelsing)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Identify the Bug or Feature request
fixes #3336
Description of the Change
Release Notes
Same as change description.
This change is