-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Biolink 4.2.0 issue with 'treats' predicates #2339
Comments
I suppose I should add - the distinction between regular predicates and mixin predicates in Biolink is becoming very confusing to me - I've reached out to Sierra about this to get some clarification. basically now some, but not all(?), mixin predicates are descendants of |
It shouldn't be difficult to use Biolink 4.2.1 in the KG2.10.1 build. Also, if you get clarification on the regular/mixin predicates from Sierra, please let me know (this has a significant impact on KG2pre as well). We are also using |
awesome, thanks! I think in 4.2.1 |
Our team suggests using 4.2.2 instead. We noticed a domain/range problem with 4.2.1 that we thought could affect the reasoner-validator (see this comment). So we waited until 4.2.2 released and are now planning to use it. |
so @mohsenht kindly brought it to my attention that PloverDB (2.10.0c) isn't answering this
related_to
query in an undirected fashion:it gives an answer as is, but if you swap the subject/object, it doesn't give any answers. which isn't how predicate reasoning is supposed to work (since
related_to
is a symmetric predicate).I traced this to an issue in Biolink 4.2.0 (which KG2.10.0 uses) where the
treats
predicate (and other treats-ish predicates) aren't listed as descendants of the overarchingrelated_to
predicate. this apparently caused issues for other teams as well (e.g., see this comment) and was fixed in Biolink 4.2.1.I rebuilt a dev Plover using Biolink 4.2.1 and the query is now answered properly (and all other Plover pytests still pass as well). I'm going to push this change so that it goes to the ITRB CI Plover, but I think we should also likely bump up ARAX/KG2 API's Biolink version to 4.2.1. I will try this in a branch and see if anything breaks..
I think Biolink 4.2.0 and 4.2.1 are otherwise similar enough that we shouldn't have issues with KG2pre being on 4.2.0 while the rest of the system is on 4.2.1, but I wonder if it would be easy enough to use Biolink 4.2.1 (or later) in the next build of KG2pre? (@ecwood)
The text was updated successfully, but these errors were encountered: