Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Definition of ssize_t in headers\carma\include\carma(28) causes CI issue on Windows #123

Open
Adarsh321123 opened this issue Jun 27, 2023 · 4 comments

Comments

@Adarsh321123
Copy link

Thanks so much for the awesome package!

I am trying to create a GitHub Action that builds the BanditPAM wheels on Windows. Here is the workflow file for reference. However, the build job fails with this exception:

headers\carma\include\carma(28): error C2371: 'ssize_t': redefinition; different basic types
C:\Users\runneradmin\AppData\Local\pypa\cibuildwheel\Cache\nuget-cpython\pythonx86.3.6.8\tools\include\pyconfig.h(174): note: see declaration of 'ssize_t' 

It seems that carma and CPython3.6 from NuGet both define ssize_t, leading to the exception. Can anyone please offer some assistance so I can ship this Action in a future release of BanditPAM?

@Adarsh321123
Copy link
Author

Just wanted to follow up on this @RUrlus!

@RUrlus
Copy link
Owner

RUrlus commented Jun 29, 2023

Just wanted to follow up on this @RUrlus!

I'm on holiday, you'll have to be a bit more patient.

@Adarsh321123
Copy link
Author

Sorry! I'll wait for your response.

@tynanseltzer
Copy link

tynanseltzer commented Jul 1, 2023

Unsure if these are the same bug but figured I'd offer if useful:

I ran into similar issues trying to build a python project that relies on Carma on Windows, specifically these two errors
c4430 missing type specifier int assumed
C3646 tsize unknown override specifier
both at line 38 of https://github.com/RUrlus/carma/blob/stable/include/carma_bits/arraystore.h
Based on pytorch/pytorch#69948
I reverted to VS2019 and python 3.9, and it then built without error. Trying either VS2022 or python 3.10 would error. Unsure the root cause of the issue, but figured this might help in debugging/fixing.

Enjoy your holiday!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants