From c74ed5d25f08e3b6f5bdb808c172b1a3b5827ef4 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pawe=C5=82=20Pacana?= Date: Fri, 29 Dec 2023 13:46:47 +0100 Subject: [PATCH] Protobuf is not going to have new binary build anytime soon So just don't test on Ruby 3.3 this gem yet. An alternative is to mess around with Ruby platform and let it compile each time. Probably de-optimizes older Ruby versions, which have a precompiled binaries already. --- .../ruby_event_store-protobuf_coverage.yml | 2 +- .../ruby_event_store-protobuf_mutate.yml | 2 +- .../ruby_event_store-protobuf_test.yml | 7 ++----- support/ci/generate | 20 ++++++++++++++++--- 4 files changed, 21 insertions(+), 10 deletions(-) diff --git a/.github/workflows/ruby_event_store-protobuf_coverage.yml b/.github/workflows/ruby_event_store-protobuf_coverage.yml index 61bcdcafb1..40eaf41c5e 100644 --- a/.github/workflows/ruby_event_store-protobuf_coverage.yml +++ b/.github/workflows/ruby_event_store-protobuf_coverage.yml @@ -35,7 +35,7 @@ jobs: fail-fast: false matrix: include: - - ruby_version: ruby-3.3 + - ruby_version: ruby-3.2 bundle_gemfile: Gemfile steps: - uses: actions/checkout@v4 diff --git a/.github/workflows/ruby_event_store-protobuf_mutate.yml b/.github/workflows/ruby_event_store-protobuf_mutate.yml index a0acefe8c7..1281c5f082 100644 --- a/.github/workflows/ruby_event_store-protobuf_mutate.yml +++ b/.github/workflows/ruby_event_store-protobuf_mutate.yml @@ -33,7 +33,7 @@ jobs: fail-fast: false matrix: include: - - ruby_version: ruby-3.3 + - ruby_version: ruby-3.2 bundle_gemfile: Gemfile steps: - uses: actions/checkout@v4 diff --git a/.github/workflows/ruby_event_store-protobuf_test.yml b/.github/workflows/ruby_event_store-protobuf_test.yml index 5b00beacfc..c51264ffb1 100644 --- a/.github/workflows/ruby_event_store-protobuf_test.yml +++ b/.github/workflows/ruby_event_store-protobuf_test.yml @@ -34,9 +34,6 @@ jobs: fail-fast: false matrix: include: - - ruby_version: ruby-3.3 - bundle_gemfile: Gemfile - database_url: sqlite3:db.sqlite3 - ruby_version: ruby-3.2 bundle_gemfile: Gemfile database_url: sqlite3:db.sqlite3 @@ -46,10 +43,10 @@ jobs: - ruby_version: ruby-3.0 bundle_gemfile: Gemfile database_url: sqlite3:db.sqlite3 - - ruby_version: ruby-3.3 + - ruby_version: ruby-3.2 bundle_gemfile: Gemfile.rails_6_1 database_url: sqlite3:db.sqlite3 - - ruby_version: ruby-3.3 + - ruby_version: ruby-3.2 bundle_gemfile: Gemfile.rails_6_0 database_url: sqlite3:db.sqlite3 steps: diff --git a/support/ci/generate b/support/ci/generate index d85ce9e1c4..a1d7254876 100755 --- a/support/ci/generate +++ b/support/ci/generate @@ -181,14 +181,28 @@ class CI matrix: join( generate( - ruby_version(MRI_RUBY), + ruby_version(MRI_RUBY.drop(1)), bundle_gemfile(GEMFILE, GEMFILE_RAILS_6_1, GEMFILE_RAILS_6_0), database_url(SQLITE3) ) ) ), - contrib_mutate("ruby_event_store-protobuf"), - contrib_coverage("ruby_event_store-protobuf"), + contrib_mutate( + "ruby_event_store-protobuf", + matrix: + generate( + ruby_version(MRI_RUBY.drop(1).take(1)), + bundle_gemfile(GEMFILE) + ) + ), + contrib_coverage( + "ruby_event_store-protobuf", + matrix: + generate( + ruby_version(MRI_RUBY.drop(1).take(1)), + bundle_gemfile(GEMFILE) + ) + ), contrib_test( "ruby_event_store-rom", services: [postgres_11, postgres_15, mysql_5, mysql_8],