forked from zom/Zom-Android-XMPP
-
Notifications
You must be signed in to change notification settings - Fork 0
/
CHANGELOG
848 lines (815 loc) · 48.1 KB
/
CHANGELOG
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
Track the source commits here:
https://github.com/zom/Zom-Android/commits/master#
15.0.1.931 (1501921) / 21 Sept 2016 / f772bda
3af5cf8 update tibetan translations
101bcb3 more fixes to layout and themeing
488984a we should load the roster by default
635f063 tweak default colors and layout
572c50f fix theme support in textview and edittext
58cef29 improve add contact dialog
556dde4 update strings
4c61f75 update the strings with new translations
dbe9217 finalize strings for add contact dialog
3afdcaf update strings
bfe2b21 don't accept manual JID unless it verifies
17d0767 use the theme background
9a48df1 don't crash if fingerprint is null
da33657 addresses #138 improve layout and display of add friend dialog
15.0.1.930 (1501930) / 15 Sept 2016 / a76305d0a9439a3838475ee75ce6c1eb1da56069
a76305d update build to 1501930
f99ad52 fix onboarding background color
15.0.1.929 (1501929) / 15 Sept 2016
b2d6d73 make the toolbar styling work for all
14b32a7 make sure all textviews are org.ironrabbit.type.CustomTypefaceTextView
4eb112b ensure the proper delete contact flow
5ab5327 improve contact detail display - add delete contact menu option - add photos sent/from contact displayed - improve layout
1ddb8c5 make sure to close cursor in case of exception
cade2b1 don't log username
04b48c6 fix construction of multi condition where statements
c49ba9b improve handling of subscription reply and add manual reapprove
08b6da7 more fixes for color theme management
79565fa more updates for themeing support
b29817d more updates for app color themeing
15.0.1.928 (1501928) / 19 August 2016 / a40645cd76396ed15a577bd666ffadbf99915698
c62de46 tweaks to session init, refresh
d86cdc4 small improvements to UI for themeing and stickers
b9ecf44 Merge branch 'master' of github.com:zom/Zom-Android
15.0.1.927 (1501927) / 17 August 2016
ebbbdf9 send postponed messages when the user comes online
9add0b6 if you get an unexpected error and aren't encrypted, refresh!
15.0.1.926 (1501926) / 16 August 2016
d90dbd7 improve handling of subscription requests and presence
8fd4a54 use the new color picker and show the lightness slider
6818e25 don't inject unnecessary error messages
53580f2 make the actionbar transparent for displaying images
771455f support flower color picker
c0640d4 a few more tweaks to style and sticker support
4de40e2 add initial multi-color theme modifications - now you can set text, background and header colors
5f23a6c tweak handling of sessions, presence, and postponed messages - handle chatstate messages in a very minimal way (iOS is not sen
0a87856 tweak image sizing
4179f18 don't optimize anything yet in proguard
e674ed4 update dependencies
3e467a6 adding new pema stickers
21d634e always pass accountId when you are creating a connection
71bca4f update changelog
dfa5703 only check updates for number updates
15.0.1.925 (1501925) / 30 June 2016
dfa5703 only check updates for number updates
f34765e change appupdater check logic to only check once per day
a1bda2e only check when version does not include a - (only when it is numbers)
27ad14e add github-based app updater support
15.0.1-RC-3 / 28 June 2016
02e5b93 improve and update presence handling code
1df1437 improve handling of sending presence
c3f0dbc don't fix the height of the line
6131b1d update to Gradle 2.1
1a889d2 handle adding contact when there is no nickname in the link
7e41283 update strings from transifex
15.0.1-RC-2 / 27 June 2016
a458da9 if the contact is null, don't set the name on it
c6ceead more tweaks to letter avatar
65c96cc List stickers in alpha order
bb33571 updated tiboji stickers
506e903 last fixes to letter avatar and sticker display
ddccf5c add support for sending nicknames in invite links, qr codes
ed93334 use customfont for avatar and enforce line height of row
36dea01 only suggest word if there is a letter!
15.0.1-RC / 12 June 2016 / 950ec7cc824d90a600d0786dada557082c8b8e35
(this is an initial massive dump into a new changelog for the v15 Zom work)
950ec7c update versionCode to 1501911
4393f61 improve support for parsing nicknames into display names to avoid crashes in case of empty nicknames
90a2b0d only send one knock/push message if the remote person is offline
85d8374 clean gradle build punctuation
238f1f8 update readme for Zom
632a3f2 update version code to 1501910
57c59bb ensure nickname is persisted and update display
2b104e5 addressing issue #110 to improve handling and display of complex nicknames/usernames
6a4cd6e improve support for nickname/display names and unicode usernames - if a user enters an entirely non alphanum username, then use "zomuser" + last octet of key instead
6910b01 don't add the commit hex code to the APK name - Android Studio can't find the apk if it is part of the name
a239ce8 update sticker cases and improve support for short codes
c42f7f4 remove debug values from display
c1c5be8 if there is no broadcast, then don't finish it
f61b794 Merge branch 'eighthave-master'
73e51b2 Merge branch 'master' of https://github.com/eighthave/Zom-Android into eighthave-master
68f66e5 15.0.1-BETA-9
186c48c update chatsecure push
ce02651 move to manually approval of new contacts/subscriptions - this was a pretty major overhaul of the subscribe/subscribed logic and flow
4053e7a name the APKs with the actual versionName
0728288 set versionName based on git release tag
401e5ee add manual new contact approval code
fdfb305 enable integrated tibetan dictionary word suggestion
621dec6 15.0.1-BETA-8
8930fed fixes #42 so that tapping on new friend brings them to open a new chat
fce4e90 Merge branch 'master' of github.com:zom/Zom-Android
64a92ee add support for new :pack-name: sticker code format
9f987d8 add additional custom external dictionary support
72c9746 Merge pull request #100 from n8fr8/master
687a43d updating stickers
a7e3609 multiple onboarding improvements but not quite at iOS look yet #94
a447b2a fixes #93 disables unsupported media sharing in group chat
911fda7 fix issue with wifi->3G connectivity fail
ee4156f attempt to fix white on white menu text
d9721d0 fixes for flow of onboarding screens
5bdbd5b Merge pull request #99 from n8fr8/master
3ba3ace before you send a knock, end the current OTR session to force refresh
625f5ca ensure contact presence is updated, and start secure session when they are online
45a679a handle cases where audio visualizer cannot work
a43be74 handle NPE
41823ec 15.0.1-BETA-7
5b8d666 remove unused strings
92ec719 disable certain buttons on groupchat - media sharing isn't supported on groupchat mode (yet!)
21c12f6 iterate safely
d74b481 don't do anything special when encryption is finished
714698e update to latest chatsecure-push
1ecad73 support sending pushes to different push provider instances
c24e352 new graphic for onboarding success
15d9a24 fixes #95 to implement new UI for onboarding
dca324f add server tokens to push token logging
0898675 update splash text and layout
feab3fe allows users to stop/finish an OTR session
ba3b640 log push tokens in debug mode for now
fb0480e if can do a push when OTR is finished, then do it!
46dd4f4 Merge branch 'master' of github.com:zom/Zom-Android
cf00886 update to 15.0.1-BETA-6
124509a Merge pull request #88 from n8fr8/master
fb148aa only show this output if in debug mode
78a7b61 fix sha256 hash for gradle version pinning
5c2a9a7 improve knock/push support reliability and message status updating
77012ab reduce memory usage of sticker bitmaps
c1c0010 address: "ZOM-01-004 Android: Complete lack of Tapjacking mitigations (Medium)" - added "filterTouchesWhenObscured" attribute enabled on key application views
53859c2 if audio permission has not been granted, don't display visualizer this required AUDIO_RECORD Permissions, so wait until the user grants it
81dc1a9 addresses: "ZOM-01-011 Android: DoS via crafted message with high size value" - limits max OTR data_len to 10MB a "sane" value, thought it could likely be smaller
323b808 address "ZOM-01-002 Android: Lack of screen capture protections" by implementing default no screen capture allowed - need to add preference to optionally enabled screen capture
93b7295 first attempt to mitigate starttls stripping bug - always require TLS (remove this as a possible preference since we don't want to support XMPP without TLS) - after connection, ensure the connection is secure, and if not, then don't share any data, don't login, and make sure to throw an exception
633245b update to latest stable smack to ensure we get bug fixes
50de38f make sure keepSignedIn is set to true and sessions are init'd properly at start
515f44f update to 15.0.1-BETA-4
908a4db fix crop image view to work on Android 6
bf50bb8 don't push toolbar off screen when keyboard opens
9dc5f19 add hot pink as a theme!
3fd7487 make sure to request subscribe from anyone you approve subscribed for
007b9ad Major improvement to message queueing for iOS knock/push and message status When a "knock" push is sent to iOS, the outoing message will be postponed until the contact comes online and a new OTR session is established. When this happens, the queued/postponed messages will be sent. In addition, proper notification of message delivery status update are now implemented, by adding the message threadID
d3c3907 gradle setting fix
b95211a space!
03a819b sychronize key methods to make sure you don't get into funky states
2c71e9e refresh is different than start; do not confuse the two! refresh will cause the old session to end start will just make sure you have an encrypted session, and if not, start one
c39a409 the expecting delivery boolean should be set before you render the message
d713d3a store key temporarily in memory in case cacheword service is killed - sometimes cacheword is killed or locked unintentionally also, we should respect the no foreground preference!
29db9bc store the key temporarily in memory in case cacheword locks
a9b77b6 don't auto-refresh when there is an error decryption as this can cause problems the otr engine will handle the errors and requery on its own
3836292 load roster at login for presence handling and lock down enabled TLS
a7c550e improve display of nicknames through user interface - shorten names for display that have a dot "." in them - make sure to show the nickname and not the address - only show qr code if there is an OTR key
651ee9c only init OTR for normal contacts, not groups
78ef78e just leave() already!
208392f use nickname variable her
7364b11 load vcard nickname and improve performance of presence handling
7cc23a0 remove history of messages stored in memory
f228e94 open a chat after you scan qr code
8caf188 reduce avatar height a bit
9102c4d move the send message icon down a bit
9a809b0 Merge pull request #84 from n8fr8/master
b1d28fd 15.0.1-BETA-3
d963a8a basic color themeing support added
175d4d5 add new "sticker share" screen and update UI for new support libs
8bbec56 update to latest android support libs and change to target to SDK 15
506b493 fix string charater escaping
5a18736 update localized strings
d72d9a8 update the string!
974e178 launch a new chat if you tap on the new contact notification
7e8eaf9 remove old style NetCipher Orbot API calls
3db1d17 clean-up message state handling
a20b68a handle the incoming intent to start chat from username + account + provider ids
e1d5f7f handle the case where imService is not started yet
878d5ba reset the auth impl here if plaintext query message comes in
8458bd2 Merge pull request #82 from n8fr8/master
a29a7c6 add camera permission support for Android 6
b2bd4c6 15.0.1-BETA-2
a3e025d add key verification options and improved QR code display
e615b86 disable debug for now
5b3185e support the glide viewer for images (work in progress)
5e7a065 don't open the fullscreen view for stickers/GIFs
b10689b always provid both the provider and account IDs
4d34114 just use the connection methods to get the provider and account variables
69f60b1 only say autologin was a success if it actually did an autologin
7ae8272 remove unnecessary debug code
3d3443c use the reconnection feature to more proactively ensure we are logged in
c25acac we should only mark OTRDATA chunks received if it is successful
985017c if there is an OTR session error, we should proactively refresh the session
27a3bc0 auth impl should be refreshed when new session is created
64d23f7 add thread pool for other important tasks
ad51bcb reconnect to account if the connection is unexpectedy closed
6b3ce5e update chatsecure-push SDK
4d55d65 setup push knock message sending support also, session status method shouldn't be synchronized, as it was causing the app to block in the UI
fcf6a86 tweak group chat setup parameters
7f8035e use custom threadpool for asynctask
7771c65 fix the issue with asynctasks not running by using our own threadpool
ef7f9b7 add sign in/sign out features to account display
85ce9f0 check if a token exists for doing push
a4c9680 more tweaks to support dynamic themeing
49c57dd start setting up main activity for dynamic theming
6bcbaa7 don't show the "[resent]" tag in messages; just deliver them properly
9d683d1 update onboarding to have more clear next/skip screen on first splash also, the back key now works from within the app "My Accounts" screen
ec9fc4c update to gradle 2.0 build tools (for Android Studio 2.0 update)
a5b9592 create our own shared, static thread pool for all chatinit async tasks
6acfa02 Merge pull request #76 from eighthave/master
b499948 improve build server performance by allowing disabling of pre-dexing
303ef3f update to fix travis build issues with lint options
3dae695 update travis config based on this advice: https://github.com/travis-ci/travis-ci/issues/3695
e02fe2b update to fix build tool issue
77a7fe1 update gitmodules to use gp version for now
73cb891 peg to gpdev master commit
77f8771 Merge pull request #75 from n8fr8/master
ff26625 15.0.1-BETA-1
baaccbb make sure we are looking for sticker:foo when using sticker codes
bbd8c51 this shouldn't be static, since there are multiple connection instances
5314413 remove avatars from message and convo queries to reduce cursor size we do separate lookups for avatars instead
af61f8d move this back to being a true AsyncTask not a thread
e440b8b This shouldn't be synchronized as it causes UI locks
771a9a7 15.0.1-ALPHA-5
2dae496 fixes for viewholder and image loading patterns throughout the UI - fixes issue with GlideVFS loading - implements proper ViewHolder get/set throughout UI - adds Glide ViewTargets in order to properly clear/reset
f295b21 ensure there is only connection per account/provide instance and also ensure all contact presence is updated in session appropriately
f504837 use smaller avatar icon to reduce memory and improve performance
fef4c98 15.0.1-ALPHA-4
3585100 tweak the way token issued is marked
e6dbe09 change the default push server endpoint
307d328 remove image view fullscreen code for now
8cffc6d remove delete option for now
33a2f7d fixed message and image resend/share features
bbaa79e directly query service for connections, and fix how connections are looked up
861d792 fix issues with account display, setting default account and updating active accounts
5914d64 Merge pull request #74 from n8fr8/master
c2d1341 just show a debug message, not an exception
a9da23e only sign in accounts that are active
3031f0c begin work to dynamically set this fragment to show the current default account
e5ca558 if the file stream is null try to reinit it
a04f666 being work to enable switching accounts for display
093f7ec remove dependence on default account global to enable multi-account use again
c00d9e6 removed unused resources to simplify localization process and make app smaller
9973fd0 small tweaks to contact display, profile and chat start handling
9a7a2b8 add basic giphy "/giphy" command for inserting stickers ala Slack
91731e4 15.0.1-ALPHA-2
6071117 change the menu search string and add underlined text
f536d60 implement message search from main screen search menu
d583776 improve display of icons and menus
a7605b0 improvements to attach chooser UI with circle imageview
13c67a9 performance improvments for recycler view lists
39704e3 add new account to accounts activity listen and improve convo list display
4082593 update the providerlistitem package and re-enable the on/off toggle
3bac243 re-enable multiple account display, delete and settings management
ec832bc Merge pull request #71 from n8fr8/dev_push
f9bc2a0 disable authentication checks for calls that don't need it we are currently just sending knocks/pushes not receiveing them
766bbdb 15.0.1-ALPHA-1
cee1860 fix new chat init task: use a more reliable thread instead!
8336107 fixes for Android 6 permissions model
2b4492f fixed issue with ImpsProvider query support
ba4ae2c re-add query for existing messages
b73497e add cacheword and PushManager inst creation
06c1acd integrate changes from dbro @OnlyInAmerica pull request doing this by hand, since my git-foo is weak, and I want to understand what is actually happening here! https://github.com/zom/Zom-Android/pull/5/files
cc94df7 remove reference to cardview library which we don't otherwise have
7dbb16c remove unneeded classes to make build work
a5730df make contact profile view more compact
29f6619 added push package from dbro @OnlyInAmerica csp branch manually adding in classes from here, since rebasing was a disaster https://github.com/OnlyInAmerica/Zom-Android/tree/csp/awesomeAppCore/src/main/java/org/awesomeapp/messenger/push
9808410 got basic push support building
cc4d17a make sure to clear previous image loading logic before starting new
4683a38 small user interface + recyvlerview improvements
aaa4bbd fix the tashi delek sticker!
2900266 update to 15.0.0-RC-2
e8bc3e2 new stickers, and improvements to sticker display
b56a7b2 improve layout and logic of onboarding and account creation
dbac668 add support for Buttons
2160c05 Merge branch 'master' of github.com:zom/Zom-Android
738eb50 update AndroidManifest
5f88154 Merge pull request #68 from n8fr8/master
66e6ec7 fixes for OTRData range handling to ensure proper start, end - also improve logic for batching requests up to max outstanding
daab0d3 update to support new query params for Gallery
b3e5689 small cleanup in display code and behavior
621871a screen on/off receiver should be in resume/pause not create/destroy
e1dfacd enable our OTRData request amount to be different than MAX allowed
e534d73 15.0.0-beta-5
e6d939a fixes #66 allows 32kb chunk, but uses 8k for its own request transfers
f33beed adding yak and dranyen tones
68438a3 fixes for custom ringtone feature
8fc0827 add support for built-in custom notification tones
ca8100b fixes #63 - when you open link to add friend, chat window is opened
a84e17c make no UI activities transparent
ad7f018 Remove Google OAuth token refresh for now (we don't have google support in Zom)
a6170af string formatting fixes for apostrophe, etc
bf1d3db Merge pull request #65 from n8fr8/master
9febc87 add and update translations
ee329e4 15.0.0-beta-4
3889e02 fixing various small NPE crash from hockeyapp logs
cbe1061 Merge branch 'master' of github.com:n8fr8/Zom-Android
2fde5e8 small tweaks to layout and styles
110cb01 fix string index issues
62786b1 fixes for OTR message handling specifically due to large OTR data shares
d6f9995 fix small issues with message layout and display
01b4778 add manual menu options for refreshing session crypto
7dc5419 fix strings
0043e32 tweak layout for buttons
a55401d 15.0.0-beta-3
b9bf58c more locale switching code to handle dialogs, lock screen, rotate - this fixes the issue where Locale would be reset when the device rotated to landscape
df8d931 Merge pull request #61 from eighthave/master
3eee348 setup panic ListPreference using panickit's convenience method
f6a717f fix NPE crash when no language pref has been set (closes #60)
85cacc6 more locale switching code to handle dialogs, lock screen, rotate - this fixes the issue where Locale would be reset when the device rotated to landscape
c59e962 Merge pull request #58 from eighthave/master
d282ed0 Merge pull request #59 from n8fr8/master
8a1a3f9 address issues recorded here: https://code.google.com/p/android/issues/detail?id=194705 (we have localized permission descriptions which should be allowed, but due to a bug, are not working in 1.5.0. They are fixed in 1.5.1 which is not out yet)
0a00957 update travis yaml
3abc8eb update build tools to v23.0.2
5b2f2b0 make language setup work for all devices, and also set default main title
ac321d8 need to reset font every time
fd2b367 Merge branch 'master' of github.com:n8fr8/Zom-Android
43dca7f fixes for custom textview to support Tibetan font
9c6568e implement "clear app data" panic response
aa573f9 switch to latest panickit release jar: 0.4
12a59ad don't generate actual QR code image for tiny QR icon
1308a73 update translations and configurations
c0f5954 update translations files and transifex configuration
18a7618 update translations and configurations
2df932e update translations files and transifex configuration
6ebe40f Merge pull request #57 from n8fr8/master
39c5c96 rename zomCore module to "app" to follow "conventions" fixes #56
1b242dc update tfx configuration
f16cabf when the screen is off, you should notify the user, even if the chat is open
3fe7bc4 move session creation to asynctask, and make message sending async as well this is to address delays in the UI when you open a chat or when you send a message, which can cause people to try and send a message multiple times
9765187 update to 15.0.0-beta-2
eabaf54 Merge pull request #53 from n8fr8/master
8ea1ab6 reduce permissions, fix permission requests
feb4399 improve gallery view icons and query
c0e6b83 add Glide library to make image loading smoother and better!
d63ca3b add a release build flavor package id
89360b3 move language util class into main zom awesomeapp package
d5f3782 fix build gradle to have a valid flavor name (cannot be "release")
29efac6 update build, add a new releae flavor with default id
c8e261f update resource package id for im.zom.messenger
7097ca4 moved awesomeAppCore to zomCore and changed package id core package is now im.zom.messenger
473a253 15.0.0-beta-1
6ce8da4 Merge pull request #51 from n8fr8/master
2174320 fix logic for various states of message delivery and encryption
14eaaca add new viewholder class
b5aae13 use proper OrbotHelper from NetCipher library
04f23fc use NetCipher instead of our own copies of these classes
0e7678e improve display of delivery and encryption icons
59d9f50 update launcher icon to Z symbol
5e3629c implement media export/share/forward/delete menu in image view widget
142c906 improve message display and viewholder pattern
588a8b7 show improved notification for inbound media sharing
300f79f fix onboarding flow issues
fea88ba add new icons for security and message status (large)
5e5106e add new icons for message state
a76e251 update to 15.0.0-alpha-34
6ee2f92 Merge pull request #44 from n8fr8/master
8770456 disable lint "abort on error" for now, due to bug with localized manifest string resources https://code.google.com/p/android/issues/detail?id=194705
db323ee small changes for gradle build
6be9082 core modifications to being support for pair-wise/multi-OTR group sessions - also general improvements in core XMPP MUC features for setting up rooms
8f92a6b allow new accounts to be created through menu option
ab7c133 make sure we switch back to send icon from mic icon
d1fd451 clean-up methods/logic for file transfer handling - also support actionmode for long press handling on specific messages
9d750c6 support the explicit value for QR size
c2db6c6 support the specified QR size
6947521 don't assume size; ask for explicit value
0edb192 simplify this - don't ever strip the resource; always use full jid
bb18835 make sure to always reinit group chat sessions after relogin
8fcf730 updating OnboardingActivity
610b110 update layouts, strings and colors for new onboarding design
fd40788 switch back to 23.0.1 build tools for travis
23fcf05 show avatar for notification large icon
e199073 if selected, show background color
673ce66 fix gradle and SDK versions
2c39b97 add contextual actionbar menu for message management still need to implement all logic and icons
6f81bc5 fix the gradle file, as it got screwed up
3900714 Initial implementation of encrypted group media sharing - added support for multiple OTR sessions per Entity, aka ChatGroup - tweaked handling of SessionID instance for groups (temporary fix, improving soon!)
4bbfaba 15.0.0-alpha-33
9834cbd make sure conversation view messages are only 3 lines long!
eb37af6 change new session start timeout/window to 10 seconds from 5
bb65041 users should never see this, but if so, don't confuse them with install messages
e966b56 this is ugly but we must handle exceptions from mount()/unmount()
ebd3264 finish() before starting new activity
c09f9ea handle empty message strings
dabad45 small tweaks to init of OTR
432a069 as a singleTask you must support onNewIntent()
883cd69 improve presence handling
88f0a38 add a commented out alternative approach
bc40ce6 add method to check if a user@domain has a key
997044a improve handling of encrypted storage and key store unlocking
4b5eb97 use our specific key manager impl subclass
bab576f use our specific key manager impl here
4b41db8 add ability find keys without the full resource
7d90de3 init the app account info in the service
f5a332c make some activities singleTask so they don't make copies this is important for lock/shutdown features
7a8fa5e update 3 jewels icon
c5b8ab9 make sure group titles wrap
ce2cbef adjust size of status icon
f4a9914 center password entry
009f90f adjust media thumbnail and status icon sizes and cropping
5a4c75c Merge pull request #41 from n8fr8/master
0ec12d9 15.0.0-alpha-32
d2149a2 don't ignore OTR message processing if the session is FINISHED
1c23138 we should keep OTR sessions around across login/logouts of XMPP layer
4a725d8 simplify the display of Me tab
3bbd093 make sure to load avatar if current one is null, but vcard is set
936bed5 more work to make sure the chatgroup title persists
ebb24c6 try out our new non-security looking privacy icon
7f98622 properly use and display the chat group name
450c495 fixes for properly supporting group chat subject updates and changes
4151882 fix issues with joining group chat
623d5ee even if there as an error adding via XMPP, let's save the fingerprint
d318ca2 add android namespace to drawable
57e6d25 fix issues with MUC creation and chatgroup session handling
98bf567 improve group presence messages
7b910e7 improve rendering of presence updates
a43496f play with new icon instead of lock icon; and make sure count is accurate
2b0f0f7 simply the crypto request message to not confuse users
551e886 layout and drawable updates to support group messages
d14021c make add contact end with opening up a new chat
26c1712 make empty state clickable
f740e71 15.0.0-alpha-31
4179755 fixes issues with group title display and chatgroup instances
da308eb handle group message duplicate delivery issue
ab42f63 create custom info page for group chats, work on updating subject and members
750b6eb update layouts to make sure they are in the right place
1d734a8 implement group/MUC chat session re-init on login
a9d3ced add easy qr code and link sharing for contacts (this let's you share a contact with another person)
464f3f7 implement contact view
e01d6b3 use constants for avatar size
30cc3d7 Merge pull request #37 from n8fr8/master
3639a60 15.0.0-alpha-30
a7cba94 make QR code sharing work
0ee00a5 make the More tab look better and suppor the create a group option
c58128b fix vcard loading/saving
6e5b16d UI tweaks and make sure to always OTR
ae9653b make sure to finish()
3135eff don't do anything with cacheword locking
23317d8 make sure to finish()
28a4fa7 modify how and when the cacheword lock affects things - we don't want to react to the lock automatically since the service can be killed
c769d0a make sure to set default to AUTO
048d352 make sure to send OTR messages to a specific resource
a6041bd fix MUC server assignement for server w/o their own use conference.rows.io as our default
7817b55 15.0.0-alpha-29
68fce60 Merge pull request #33 from n8fr8/master
d4b8f39 start implementing better contacts, clean-up UI list a bit - fixes #18 with landscape squish
54a2b42 fix issue with password setup option not appearing
ef90f24 update to support higher res avatar display
90f8936 get higher res large avatar icon
f4534bc update to support new method for avatars
2839573 support easy access to square avatars
4580483 15.0.0-alpha-28
4fb393d checkForUpdate() just in onCreate()
4b7a909 check for updates onResume()
07973ab if there are no contacts, always show the invite prompt
c944b2a show a message when you have no contacts
297b3fd small tweaks, improvements in layout and colors
7767b28 fix DNS lookup and handling of memorizing trust manager certificates
0fed8dc use the new Smack DNSUtil
a9d3c66 remove unnecessary graphics and modify existing ones
2e868d8 remove <3 heart action for now
1f16179 switch to using MemTrustMgr build from jitpack.io
0bfc4c2 Merge pull request #32 from n8fr8/feature_lock_22
b49d858 15.0.0-alpha-27
f9196b9 fix conversation layout/scrolling to stack from bottom
4f43a88 small fixes for cacheword and lockscreen handling - don't pre-emptively close ImpsProvider db when cacheword locks. Cacheword can lock unexpectedly when the service is killed. - make sure main screen is shown after successful login - tune the init of SecureMediaStore/VFS so it doesn't happen if already mounted
3ecd61f 15.0.0-alpha-26
aeb4aa2 more tuning of lock logic and flow on unlock
753958b fix presence parsing to ensure we show the person they are online
6d37422 only enable tibetan font if keyboard is enabled (for now)
2c763d8 fix autoLOgin flow for new lock logic
bd50903 add new tibetan novo font built-in
a40430f dont' auto-init here anymore; it is the wrong place to do it
d8f9672 more improvements and fixes for lock screen flow
59a4f3c handle null cursors if the database is closed
31a1f00 make sure you properly clear the temp passphrase
00022f8 make sure the stopForeground() is always called
b96aab9 added support for setting lock passphrase, changing lock passphrase
f99a3d2 Merge branch 'eighthave-panic-lock-update'
2c3ddda wire up "Uninstall App" panic preference
2776a0f fix Done button in Panic Setup when called from within the app
5b7cbc7 smooth out panic triggering shutdown/lock
1ebfbc4 de-couple lock from others in panic setup
e70fc93 re-enable shutdown/lock on main menu
e3ee949 fix crash on shutdown/lock with progress dialog
a94b0dc clearing the XMPP account passphrase breaks Zom's working assumptions
562bf4a remove unused SignInHelper block from RouterActivity
53ca4d8 cacheword is required for zom to run
641fdd6 set up interlocking checkboxes for Panic Setup
2c23e7d put "Languages" on top of prefs
2911fdf add UI template Activity for Panic Setup
9c0f870 Merge pull request #24 from eighthave/purge-branding-fix-languages
6461f6a travis-ci: disable emulator until we can get it stable
d34a733 remove MemorizingTrustManager cruft
00f4238 delete extraneous text in awesome_fragment_account.xml
231b224 remove AccountViewFragment registration from AndroidManifest.xml
dcc008b remove MissingChatFileStoreActivity again from AndroidManifest.xml
1eb947c add new pref group: "Protect My Data"
d15de44 revamp language switcher to hopefully work more reliably
383808d purge unused methods from ImApp
814e648 purge ancient "branding resources" entirely
9879e42 purge unused "private resources"
1ed079d use gradle variables to handle common settings across subprojects
1cdd6aa reduce javaMaxHeapSize for those of us without 8+ gigs of RAM
f940edf add SHA256 sums for new support libraries added in b0fe456c3618efe44bb17cd143d54415edd73ba2
efcb068 update travis-ci build to android-23 to match app
11a3e79 Merge pull request #23 from n8fr8/ui_sprint1_oct2015
ba25314 15.0.0-alpha-25
00f3d94 when you open the keyboard to type, last message propely shows
3258e9a re-add bitmap cacheing back in
4ba9b35 update to 15.0.0-alpha-24
414d45e fixes #19 advanced onboarding now works!
334fe9b fixes #20 back button in onboarding
afd6985 more UI adjustment for better chat flow
3545862 multiple updates for screen/UI/message display and flow
aae9552 broke by SDK 23 and fixed (but not actually used)
b23cb6f small fix related to SDK 23 update
b0fe456 update to SDK 23 and include apache http legacy - we need this for some of the fixes in design and support libraries
47e3346 attempt to auto-init chat sessions for all loaded conversations
b75a9f9 remove debug output printing
ad8da38 tweak justification and spacing issues for messages and input box
512c512 updated notification icon
02bbbf1 address #10 to make sure recording is actually happening also catch ISE if it happens
3f7d426 if thumbnail image load fails, don't hide the thumbnail view!
0f571f0 implement infrastructure for resending messages (without re-persisting them)
20fdd52 Merge pull request #8 from n8fr8/ui_sprint1_oct2015
c02c07f turn off debugging for build
eb54b4d update to 15.0.0-alpha-23
07c0316 final fixes for groupchat setup, to use default conference server on domain
901eedc clarify presence handling
ea0a733 update our server list
4e9aada Merge branch 'ui_sprint1_oct2015' of github.com:n8fr8/Zom-Android into ui_sprint1_oct2015
b3b017f trying to fix group chat
ec9d845 improve contact delete user interface
9df2495 tweaking bulk presence update
190061f lazy save VCard/avatar to the server this was causing a big drag on login
fc2ada4 fix zom.im URL handler to handle links without fingerprints
07dfb40 clean-up unique username generation, and only try once per server now that our generate usernames are guaranteed to be unique, we don't need to do silly things like append incrementing integers to them
79cbb25 improve onboarding to reduce change of errors - generate unique user name by appending OTR fingerprint - properly update accounts table in database
1018bc3 update list of supported servers
f9003c2 update launcher icon to be bigger
35b70a1 use the default conference server provided by the service
233cc56 don't use a different theme for the QR code scanning activity
df5ad1e handle links without an OTR fingerprint
1b2ba38 autoLogin() only should happen once, not in onStartCommand()
c1d4f56 improve contact add flow, UI, and handle links w/o fingerprints
02af463 update icon
1bc3442 fix zom.im URL handler to handle links without fingerprints
57837ed clean-up unique username generation, and only try once per server now that our generate usernames are guaranteed to be unique, we don't need to do silly things like append incrementing integers to them
04d09da improve onboarding to reduce change of errors - generate unique user name by appending OTR fingerprint - properly update accounts table in database
0a43aca update list of supported servers
9371894 update launcher icon to be bigger
22f1202 use the default conference server provided by the service
36a26da don't use a different theme for the QR code scanning activity
d8923c1 handle links without an OTR fingerprint
5889636 autoLogin() only should happen once, not in onStartCommand()
c960bb3 improve contact add flow, UI, and handle links w/o fingerprints
816908f update icon
ee2441b Merge pull request #6 from n8fr8/ui_sprint1_oct2015
bdf842c user the default chat server available on the current box
2128c50 send stickers async, in case session needs to be created
691e81f fix inbound group sticker rendering (issue with appended whitespace)
5731ddb support "/sticker" command for MUC sticker sharing
da88c3c use info icon instead of shield for conversation detail
dfd951d add new info actionbar icons
e58c20c Merge pull request #7 from eighthave/default-panic-and-prefs-update
b65643f purge unused translations, fixes lint ExtraTranslation
6aeb5b8 include gradle-witness pins for zxing and sqlcipher
d922f2b add preference to select Panic Trigger app
c135858 purge "Dark Theme" preference, it is entirely unused
df15ecd arrays.xml no longer needs to be translated
b3015ff always use internal data store for chat logs and media
21818e1 remove global preferences from Imps.ProviderSettings
4ee12a2 use constants for return values in SettingActivity
16bd7a5 handle incoming Panic.ACTION_TRIGGER Intents in RouterActivity
a7d4450 allow shutdownAndLock() to be called with a Service or Context
ce6afbc use constants for Intent Extra names for easy traceability
fa2757b use string resource for "Chat Encryption" in preferences
5db37c5 15.0.0-alpha-22
1a0b844 improvements in async sending and handling offline sending/queueing
085c89c improve XMPP session reconnect handling and related functions for online/offline sending support
572c906 add missing android smack dependency
7e76052 15.0.0-alpha-21
67321ab fix crash for group chat sticker parsing
ed9c8d2 make the size of the contacts/people tab bigger
3593a6f change conversation menu to info icon from shield
2fbf0d6 don't show fav/resend/share icons for non-JPEG photos
29c9c0c support stickers in group chat using /sticker cmd this makes it not necessary to share sticker PNG files for group chat
3ea7dc7 set the new icon for the discover tab
5001f06 make the set avatar fit on smaller screens
f13bb91 step 1 to making the Me tab look better
f468452 small layout improvements to the discover tab
0010b41 new explore/more tab icon
cb0265a new launcher icon (just testing it out!)
f635aaf Merge pull request #4 from n8fr8/ui_sprint1_oct2015
18e8f4f Merge pull request #3 from n8fr8/master
49c8241 update 15.0.0-alpha-20
e8118b4 properly handle swipe to delete
8770dd1 improve on swipe to delete/block contact
7aee2c1 add avatar setup in onboarding
d10c615 tune notification of invite accepted
c053a20 implemented swipe to remove contact with confirm UI
a81b79b add basic notification for new contact added/accepted
1db059d think about adding new menus
b2f21a0 even if app is no signed in, as long as it exists, go to main
c83fcc4 add final new stickers
5c826ec add support for new stickers
1d52dc1 remove local sqlcipher and zxing and use gradle depends instead
432e0ff remove stickers from here
1e1e0bf remove art zip
a79f43b compressed size
0145c97 add new sticker assets
037354c update to 15.0.0-alpha-19
faf70e6 implement new add contact dialog
a0c5ac5 update manifest to 15.0.0-alpha-18
1fa8eb5 add online/offline toggle
d799302 improvement of the conversation detail view layout
d889621 hide FAB when on more/discover tab
0623441 add photo capture support into gallery activity
ae6ea61 putting "more" tab back in and removing direct invite options from contacts
a67ce14 remove zxing-core in project (using gradle depend now)
6c7604f use official zxing-core gradle source
98e19bd travis-ci: use `./gradlew build` to assemble and run checks
3999bbc travis-ci: build only with openjdk7 to make emulator tests reliable
c146abc set long timeouts for tests to prevent errant failures in Travis-CI
ed0af8f Merge pull request #1 from eighthave/master
ee42c82 purge unused legacy code
a892573 fix crasher bug when initing stickers
051421a show Toast if an immo: URI is received, its not yet implemented
2cc7cb2 make sure WiFi is not required
2a8f15c fix syntax error when using READ_PHONE_STATE permission
a19432d fix lint error "Right-to-left text compatibility issues"
8c5048f fix lint error: "Too Long Log Tags"
53526b8 fix lint error "Incorrect constant"
df14a86 fix lint: "Missing Super Call" for onFinishInflate
2fac6a6 remove unused strings from translations (warning_alpha and muc_dialog_room)
a7de912 fix javadoc issues to help make senses of all this
7c6244c use apply() instead of commit() for SharedPreferences
9585a4f remove errant text in layout XML
5336c3b set minimum SDK to android-14 aka Android 4.0 aka Ice Cream Sandwich
2e8b049 otr4jandroid: only set versionName and versionCode once, in manifest
f66eec5 fix spelling errors that lint complained about
aaee56b Remove system-app permissions that this app can never use
9b6666f remove duplicate and unused android:id
76cf47f remove unused passphrase_view.xml
6bd3e04 android:pathPattern attribute should start with '/'
5164119 use symlinks to provide alternate folders for Hebrew and Indonesian
1683975 re-enable lint errors, lint is our friend
91238ab fix lint ResourceAsColor error
29d908d travis-ci: update to latest Android SDK tools before build
b63d225 travis-ci: if build fails, cat all lint results to the build log
1f68f65 delete files that are ignored in .gitignore
60f5b57 use gradle android plugin v1.3.x
1273f06 add sha256 sums for all downloaded jars
445bd78 update support libraries to all use the same version: v22.2.1
f91f271 update gradle wrapper to include gradle binary pinning
7e83508 update to latest SQLCipher to fix missing shared libraries
e0b670e clean up awesomeAppCore dependencies
7fab373 clean up gradle build
6b2e6bd get jsoup from the repositories
bb60cd4 run tests on OpenJDK and Oracle JDK
3a5aba7 use official release of IOCipher v0.3 from jcenter
dd40084 travis-ci: rework execution order to conserve memory
e377e0a use cacheword v0.1 official release from jcenter
c744ca8 travis-ci: support running tests on emulator
9ca0d19 set up repository for Travis Continuous Integration
186b4f2 15.0.0-alpha-17
d080a32 update project files
94dd691 update build files for new guardianproject AARs
3e96378 simplify dialog box
b28f59c have auto-incrememented name appendages be 1 based
68cb539 remove unused extensions and change debug tag
d838139 simplify the group chat dialog
70c2d2e update libraries and remove old/unnecessary ones
f56615b Merge pull request #1 from OnlyInAmerica/awesomeapp-ui
a576908 OnBoardingActivity: Back button behavior
2c12bd7 modify awesome_onboarding
48ff33d fixed onboarding issues with low socket timeout new onboarding was frequently not working due to network timeout
8ff3e1e 15.0.0-alpha-15
47bcf14 more tweaks for onboarding and group chat setup
c97b916 fix DNS SRV lookup and MUC form submission
f701c6f tweak colors, layout and menu items
0f32322 update the server list with connect server info
4806bf5 more progress on groupchat
b32ab7e don't show groups in contacts list
000ba38 cached bitmaps will be loaded outside of the task
143c850 improve performance of gallery loading
2adaa45 more fixes for group chat UI workflow and session management
73954c7 make it possible to invite new people to a group chat
20e0741 fix NPE on using wrong contact instance
787e0ea fixed send/mic icon switch state in chatview
1b381af make the logic for new account reg try a server multiple times it will iterate the username with a number
775ba6e fix check for existing ChatGroup (was causing NPE)
87b32ad more progress on MUC group chat flow - handle invites to group chats automatically - don't show inbound messages from ourselves - handle status contact presence management from MUC
787aa08 improvements to group chat setup through multiselect contacts
253fa86 tune the display of inbound messages from group chat
8214275 change background color of onboarding to be slightly less magenta!
4cb1bab properly handle multiselect in contacts picker
f7c69e3 disable main debug flags
06874b3 update manifest 15.0.0-alpha-14
9f96332 make it possible to show password on account tab
0c0ec56 add group chat menu in here
4f82e68 fix MUC setup and VCard load/save
33aab6a add dukgo.com and rows.io back in
67f4133 project file updates
4736374 this needs to be synchronized to avoid double key rotation
e971611 add new activity
ebc4928 final fixes for Smack 4.1 update RACE condition was occuring with OTR ratcheting due to increased speed of XMPP packet/message stanza delivery, and batching of messages into one stanza Made handleDataMessage synchronized! Also other improvements in autoLogin, handling delivery receipts, and more
1eb4879 layout and graphics updates
270b0c4 various small pieces of UI improvements and status update checking
3d293a8 add new conversation view
506a9f0 fixes for message, convo layout and UI performance
58a70b3 add new memorizing activity for memtrust support
c345803 other library updates
8153f0b update memorizingtrust to latest code
8efa7ad move to official smack 4.1 repo
9cd6604 handle starting of service from onboot properly
1e36b69 reset the image immediately to a placeholder while we load full image
5284ac9 address crash with QR code scan by delaying autofocus also catch the exception if it does crash!
cde100d remove import summary
6f83759 no more git submodules with gradle config
dd60517 update git ignore
7fb099c remove build files
563fd9a remove unneeded files
93735e4 make sure the service restarts properly if it was killed
6067c5d fix contact item crash and update to 15.0.0-alpha-13
8f1a8b6 update to 15.0.0-alpha-12
9bc0a7c fix issue with importing photos where mimeType is null
8e7a8e2 fixed sharing of updated vcard presence hash
1f64a82 more fixes for avatar loading/saving
8d419c1 implemented most of avatar setting, loading, and display still working out some bugs and quirks!
ef2f73c fix chat notifications so that they open the appropriate window
4c79307 add GP repository to gradle build
9144603 add new project art files
03695dc remove APK files
73d564c 15.0.0-alpha-11
1174b86 improve account display "me" tab UI display
839ae50 improve layout of timestampe on contact view
38c23f5 improve layout and performance of message, gallery, contact views - centralize thumbnail loading tasks - use prettytime formatting - fix sticker sharing ... and more!
6790d5b improved audio and image loading via new asynctask also added pause/play logic to audio playback
10546be supporting sending/playback of large external audio files (or any file) don't import external files into iocipher/vfs store when sending also support playback for external audio files when shared receive side will still store in IOCipher
3b3812e 15.0.0-alpha-10
c2a0fe9 fix UI hang at load time, and duration setting
4ae8a3f handle async load of contact thumbnail to stop hanging
7360df3 fix audioplayer to load more smoothly
b8e3847 switch audio to AAC/M4A format for cross-device compat
e4fcf66 enhance audio playback with visualizer widget
2efc6d4 fix onboarding NPE crash on null domain
d8b4f19 remove waveform project (too bloated, and not needed)
272d665 add new waveform-android module for sound visualization
37b7f21 more broad UI updates for new account flow
e1d9ffc improve onboarding "success" screen
5a72450 change core tab layouts back to include contacts
efe6942 change onboarding invite message to just use nickname/username not full jabberid
62cd93c moved contacts fragment back to primary tab screen
8fb24c8 add new zom UI strings
589253b update layout for media sharing options
d52ccbd new icons for media sharing
1af1138 fix media file resharing (VFS URI) and add simple action icons
fc2612a add initial media reshare feature
67a7058 handle rotation of camera (which causes activity to restart) we must save/restore state of the activity
e887e18 properly show/hide keyboard and attach/stickers area when used
0bffd48 only check for updates when activity is created
ee447f3 update version
607eab6 continued small UI updates
48cab69 re-enable verify menu and enable auto OTR
43a9cfa add reverse sort for messages
2c834c2 add tab title support and import/take photo for gallery
e592b59 improve roster subscription logic
fa021f5 improve onboarding UI and make sure all usernames are legit
61b290c add zomkyi stickers and compress all much smaller
ed98d2c re-implement hockeyapp upgrade check functionality
408ef05 fix notifications so they open the appropriate activity
a777af0 prepare to add last message or last seen time value
49bf896 handle when contact might be null
205612f update and simplify menu
a1c02e2 15.0.0-alpha-7
ab8af59 added in sticker support with first built-in stickers
27dc6ef reimplement manual query reschedule/requery to ensure accurate view
268c9d7 improve voice message UI including drag to delete
4a9ab41 add "add" manual jabber contact add feature to invite pane
70052d1 update to 15.0.0-alpha-6
dc366a8 re-enable settings and group chat menu, and fix other icons for menus
6754109 add new gallery view for all shared images
247e067 new icons
e90e285 getting ready to add stickers
06d9e21 general onboarding, qr scan, and new chat flows
baa0a21 fixes for subscribe management and adding contacts/lists
6246528 only use jabber.otr.im for now
677517f add new icons and sizes
34756a4 add empty list messages/views
4fa8460 update gitignore
c9a20bf update project files
495f419 update link invite format to match Chris' new spec
8c98e3b change foreground notify message
df8af99 don't all inbound messages for contacts that don't exist
73abcbd small styles updates for compat
f9218d7 remove zxing core build
449502b remove memtrust build
52a8eb3 remove build for tibetan text library
a84c135 update gitignore and project files
f5f85da fix issue with styles and colors
33e06fc remove build artifacts from git repo
f3236c3 adding in logo, icon and sticker resources
6d7b229 awesomeapp grade and package major refactor
03f5f89 handle errors thrown lower in the stack here
78c66f1 handle connection being null
f6be4d9 this is not used anymore
5606e08 no need to clear this
c1c18fe handle possible NPE