Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addressed a Typo in IRC validation #52

Merged
merged 1 commit into from
Jan 6, 2020
Merged

Addressed a Typo in IRC validation #52

merged 1 commit into from
Jan 6, 2020

Conversation

nateharms
Copy link

In RMG 2.4, creating a RMG molecule from smiles would look like this Molecule(SMILES='smiles_string'). However, when RMG was updated to python 3 the naming convention changed to Molecule(smiles='smiles_string'). This PR addresses this for validation of IRCs.

@codecov
Copy link

codecov bot commented Jan 6, 2020

Codecov Report

Merging #52 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #52   +/-   ##
=======================================
  Coverage   63.25%   63.25%           
=======================================
  Files          27       27           
  Lines        4629     4629           
=======================================
  Hits         2928     2928           
  Misses       1701     1701
Impacted Files Coverage Δ
autotst/calculator/gaussian.py 63.37% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 25067c7...951b4ee. Read the comment docs.

Copy link
Collaborator

@davidfarinajr davidfarinajr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@nateharms
Copy link
Author

The only issue at the moment is the the patch doesn't hit the target coverage. This is because these lines of code weren't tested before. A todo should be to add tests to this in the future. See issue #55). Will take care of this soon.

@nateharms nateharms merged commit 9c23395 into master Jan 6, 2020
@nateharms nateharms deleted the irc_fixup branch January 6, 2020 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants