UITextField return command #118
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdiep
requested changes
Nov 2, 2017
|
|
||
| if (command == nil) return; | ||
|
|
||
| disposable = [command.enabled setKeyPath:@keypath(self.enabled) onObject:self]; |
There was a problem hiding this comment.
I think this needs a -asScopedDisposable in order to not leak when the UITextField is deallocated.
There was a problem hiding this comment.
Neither UIBarButtonItem (RACCommandSupport) nor UIButton (RACCommandSupport) make use of RACScopedDisposable in the same case. Do you think all of them should be revised to address this problem?
There was a problem hiding this comment.
I would think so, but I'm honestly not sure. I'm not very familiar with this code.
There was a problem hiding this comment.
Me too) So I should investigate more into this possible memory leak but can't do it right now. Will try to look at this soon.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a command for the Return key.
Unfortunately I have no experience with Quick system at all. I've diligently copied UIButton test's implementation but have no idea regarding is it working or not.