Fixes #47 : RACMulticastConnection should reconnect after disposal. #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdiep
reviewed
Dec 4, 2016
| @@ -45,15 +45,16 @@ | |||
| expect(@(subscriptionCount)).to(equal(@1)); | |||
| }); | |||
|
|
|||
| qck_it(@"shouldn't reconnect after disposal", ^{ | |||
There was a problem hiding this comment.
The fact that there's a test for this means that the behavior is intentional.
I'm not entirely sure why this is the case. Maybe one of the other maintainers does. But I'm not personally comfortable accepting this PR given how little I know about it.
There was a problem hiding this comment.
Yes it is intentional. But it should reconnect because it is the way it works in the original Rx (C#).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #47 !