You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug
The test for equality of Notifications in tests uses str equality instead of equality leading to false negatives
To Reproduce
ReactiveTest.on_next(300, Decimal(0)) ==ReactiveTest.on_next(300, Decimal("0.0")) # false even though Decimal(0) == Decimal("0.0") is trueReactiveTest.on_next(300, {"a": 42, "b": 5}) ==ReactiveTest.on_next(300,
{"b": 5, "a": 42}) # false though {"a": 42, "b": 5} == {"b": 5, "a": 42} is True
Expected behavior
Above examples should be equal
Code or Screenshots
This is caused by using string inside class Notification(Generic[_T]):
defequals(self, other: "Notification[_T]") ->bool:
"""Indicates whether this instance and a specified object are equal."""other_string=""ifnototherelsestr(other)
returnstr(self) ==other_string
RxPY version: 4.0.4
Python version: 3.11.2
The text was updated successfully, but these errors were encountered:
Describe the bug
The test for equality of Notifications in tests uses str equality instead of equality leading to false negatives
To Reproduce
Expected behavior
Above examples should be equal
Code or Screenshots
This is caused by using string inside class Notification(Generic[_T]):
The text was updated successfully, but these errors were encountered: