diff --git a/cli/objects/job.py b/cli/objects/job.py index 96e4e7ff..d5c84230 100644 --- a/cli/objects/job.py +++ b/cli/objects/job.py @@ -326,11 +326,10 @@ def _find_failures(self, logs_dir: str, junit_dir: str) -> Optional[list[Failure # Combine lists into one list for failure in itertools.chain(test_failures, pod_failures): if failure.step not in unique_steps_with_failures: - unique_steps_with_failures.update([failure.step]) + unique_steps_with_failures.add(failure.step) if self.firewatch_config.failure_rules: for rule in self.firewatch_config.failure_rules: - if rule.matches_failure(failure) and rule.ignore: - failure.ignore = True +failure.ignore = rule.matches_failure(failure) and rule.ignore failures_list.append(failure) if len(failures_list) > 0: