v1.0.3 Fixed setODR() bug

Reefwing-Software · Feb 20, 2023 · 7011f2c · 7011f2c
1 parent 289a961
commit 7011f2c
Show file tree

Hide file tree

Showing 7 changed files with 21 additions and 15 deletions.
diff --git a/examples/readAltitude/readAltitude.ino b/examples/readAltitude/readAltitude.ino
@@ -5,11 +5,12 @@
   @copyright  Please see the accompanying LICENSE file.
 
   Code:        David Such
-  Version:     1.0.2
-  Date:        20/02/23
+  Version:     1.0.3
+  Date:        21/02/23
 
   1.0.1 Original Release.                         11/02/23
   1.0.2 Added 2's comp for temperature            20/02/23
+  1.0.3 Fixed setODR() bug                        21/02/23
 
   Acquires temperature and pressure readings from the LPS22HB
   Pressure Sensor mounted on the Arduino Nano 33 BLE Sense

diff --git a/examples/readPressureUnits/readPressureUnits.ino b/examples/readPressureUnits/readPressureUnits.ino
@@ -5,11 +5,12 @@
   @copyright  Please see the accompanying LICENSE file.
 
   Code:        David Such
-  Version:     1.0.2
-  Date:        20/02/23
+  Version:     1.0.3
+  Date:        21/02/23
 
   1.0.1 Original Release.                         11/02/23
   1.0.2 Added 2's comp for temperature            20/02/23
+  1.0.3 Fixed setODR() bug                        21/02/23
 
   Acquires temperature and pressure readings from the LPS22HB
   Pressure Sensor mounted on the Arduino Nano 33 BLE Sense

diff --git a/examples/readTempAndPressure/readTempAndPressure.ino b/examples/readTempAndPressure/readTempAndPressure.ino
@@ -5,11 +5,12 @@
   @copyright  Please see the accompanying LICENSE file.
 
   Code:        David Such
-  Version:     1.0.2
-  Date:        20/02/23
+  Version:     1.0.3
+  Date:        21/02/23
 
   1.0.1 Original Release.                         11/02/23
   1.0.2 Added 2's comp for temperature            20/02/23
+  1.0.3 Fixed setODR() bug                        21/02/23
 
   Acquires temperature and pressure readings from the LPS22HB
   Pressure Sensor mounted on the Arduino Nano 33 BLE Sense

diff --git a/examples/setODR/setODR.ino b/examples/setODR/setODR.ino
@@ -5,11 +5,12 @@
   @copyright  Please see the accompanying LICENSE file.
 
   Code:        David Such
-  Version:     1.0.2
-  Date:        20/02/23
+  Version:     1.0.3
+  Date:        21/02/23
 
   1.0.1 Original Release.                         11/02/23
   1.0.2 Added 2's comp for temperature            20/02/23
+  1.0.3 Fixed setODR() bug                        21/02/23
 
   Acquires temperature and pressure readings from the LPS22HB
   Pressure Sensor mounted on the Arduino Nano 33 BLE Sense

diff --git a/library.properties b/library.properties
@@ -1,5 +1,5 @@
 name=ReefwingLPS22HB
-version=1.0.2
+version=1.0.3
 author=David Such <[email protected]>
 maintainer=David Such <[email protected]>
 sentence=Arduino Library for the LPS22HB Pressure Sensor.

diff --git a/src/ReefwingLPS22HB.cpp b/src/ReefwingLPS22HB.cpp
@@ -5,11 +5,12 @@
   @copyright  Please see the accompanying LICENSE file.
 
   Code:        David Such
-  Version:     1.0.2
-  Date:        20/02/23
+  Version:     1.0.3
+  Date:        21/02/23
 
   1.0.1 Original Release.                         11/02/23
   1.0.2 Added 2's comp for temperature            20/02/23
+  1.0.3 Fixed setODR() bug                        21/02/23
 
   Credit - Some code used from the LPS22HB Absolute Digital Barometer 
            class  by Adrien Chapelet for IoThings.
@@ -114,7 +115,7 @@ void ReefwingLPS22HB::setODR(Rate rate) {
   _rate = (uint8_t)rate;
 
   //  Set ODR bits 4, 5 & 6 (_rate & 0x07) << 4 and BDU 0x02
-  write(LPS22HB_CTRL_REG1, ((_rate & 0x07) << 4) & 0x02);
+  write(LPS22HB_CTRL_REG1, ((_rate & 0x07) << 4) | 0x02);
 }
 
 void ReefwingLPS22HB::setQNH(float q) {
@@ -184,7 +185,7 @@ int16_t ReefwingLPS22HB::twosCompToInteger(uint16_t two_compliment_val) {
     uint16_t sign_mask = 0x8000;
 
     if ( (two_compliment_val & sign_mask) == 0 ) {
-      // if positive
+      // positive number - do nothing
       return two_compliment_val;
     } 
     else {

diff --git a/src/ReefwingLPS22HB.h b/src/ReefwingLPS22HB.h
@@ -5,11 +5,12 @@
   @copyright  Please see the accompanying LICENSE file.
 
   Code:        David Such
-  Version:     1.0.2
-  Date:        20/02/23
+  Version:     1.0.3
+  Date:        21/02/23
 
   1.0.1 Original Release.                         11/02/23
   1.0.2 Added 2's comp for temperature            20/02/23
+  1.0.3 Fixed setODR() bug                        21/02/23
 
   Credit - Some code used from the LPS22HB Absolute Digital Barometer 
            class  by Adrien Chapelet for IoThings.