This repository has been archived by the owner on May 5, 2023. It is now read-only.

Review fork customization #11

Draft

stevenjonescgm wants to merge 4 commits into master from review_fork_customization

stevenjonescgm commented May 26, 2021

Opening this Pull Request to re-implement changes derived from #10, on top of current upstream alvarcarto/master

In my opinion,

the changes to render defaults should be rejected (should be implemented application level as options)
reconsider the utility of increasing scroll timeout from 30s to 120s
test and perhaps ship the logging truncation (I copied code from other branch without test, also consider extracting these values to application options)

stevenjonescgm added 4 commits

May 26, 2021 16:05


          update render defaults

69766db


          update scroll timeout from 30s to 120s

914c2b5


          truncate url in logging to 300, if > 1024

d78ec09


          use deepSupressLongStrings for logging request body (like headers and…

37cb5ed

… params)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet