Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile updates for 1.2-DRAFT #376

Merged
merged 18 commits into from
Dec 9, 2024

Conversation

elichad
Copy link
Contributor

@elichad elichad commented Dec 4, 2024

  • changes tip/note/warning messages to ETT style (only in 1.2-DRAFT for now, but could also do this in 1.1)
  • Makefile updates:
    • upgrade panflute to 2.1.3 (<2 doesn't work on my machine)
    • use nav_order for appendix as well as main spec
    • change sed scripts to find/replace the new message boxes for the PDF
    • update sed scripts for internal links as these weren't working properly
  • change <div id="provenance"></div> at start of pages to # Title {#page-name} (i.e. a custom heading ID) to support the single-page links better
  • Conda env updates: versions not chosen with a lot of care, just newer versions that work with the Makefile where the old ones didn't
    • upgrade panflute to 2.1.3
    • upgrade nodejs to 14.8

With these changes I'm able to run the Makefile on my machine and generate a PDF with working internal links.

One thing still to do is fix the images in the PDF - pandoc doesn't handle the raw HTML in introduction.md well

@elichad elichad requested a review from stain December 4, 2024 16:37
Copy link
Contributor

@stain stain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, just remove the scripts/pandoc-admonition.py calls now from Makefile

@elichad elichad merged commit 12a6454 into ResearchObject:main Dec 9, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants