Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modal-group + mobile-target inconsistent in Google Chrome #113

Open
fotografitti opened this issue Jan 27, 2019 · 2 comments
Open

modal-group + mobile-target inconsistent in Google Chrome #113

fotografitti opened this issue Jan 27, 2019 · 2 comments
Milestone

Comments

@fotografitti
Copy link

In Google Chrome:
If I add data-modal-mobile-target="..." to grouped images, with the first call, (on a mobile device) it opens the lightbox. Then pressing the arrow, it shows the mobile target (so just the picture).
In Firefox it works as expected ans opens just the image and then one has to go back.

Also in Chrome I get a warning in the console: [Violation] Added non-passive event listener to a scroll-blocking 'touchstart' event. I think its related, but my javascript knowledge is limited and I was not successful fixing it...

@JimBobSquarePants JimBobSquarePants added this to the V5.0.0 milestone Jul 25, 2019
@JimBobSquarePants
Copy link
Member

Hi @fotografitti

Apologies for the slow reply.

In Google Chrome:
If I add data-modal-mobile-target="..." to grouped images, with the first call, (on a mobile device) it opens the lightbox. Then pressing the arrow, it shows the mobile target (so just the picture).
In Firefox it works as expected ans opens just the image and then one has to go back.

I'm not sure I understand. Are you testing this on a desktop browser?

Also in Chrome I get a warning in the console: [Violation] Added non-passive event listener to a scroll-blocking 'touchstart' event. I think its related, but my javascript knowledge is limited and I was not successful fixing it...

I'm currently working on v5 and will look at this as part of that release.

@JimBobSquarePants
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants