Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Demos are where? #25

Closed
anselmh opened this issue Dec 13, 2012 · 6 comments
Closed

Demos are where? #25

anselmh opened this issue Dec 13, 2012 · 6 comments
Labels

Comments

@anselmh
Copy link
Member

anselmh commented Dec 13, 2012

Hi, I am confused by demo-repos on RCIG.

Found out you have demos incl in respimg.org repo but commit doesn’t show up?
Now saw that here in 'demos' there is a branch 'polyfilled' containing some demos.

What is the right place to merge new demos in? And what about the others?
If you can shortly explain I can organize and remove unnecessary branches.

@baamenabar
Copy link
Member

Yes please.
Also, could there be a link, in the demos page, to the repo with the template?

@marcoscaceres
Copy link

@anselmh, very sorry about the confusion. This is my fault. What happened was that when RICG site got updated, the demo pages all started falling out of sync (e.g., the header and footers). So, I decided that I would move the demos to responsiveimages.org/demos/

My plan is now to rip out templatize the demos to make their maintenance easier: i.e., the headers and footers become consistant and only come from one source, etc.

Hopefully that makes sense now.

@baamenabar, @anselmh created bug: #26

@anselmh
Copy link
Member Author

anselmh commented Dec 15, 2012

Sounds like a good plan to only ask for the real content inside of <div id="main"></div> and serve the rest from a mini-template included (via php?).

To clarify: Is the demo's repository (branches especially) obsolete now or is it still used somehow? That currently causes most confusion. Also I pushed the demo by baamenabar to the respimgcg.org repo but still nothing happened…?

@marcoscaceres
Copy link

@anselmh I've pushed the new demo to the website today. The website and the repo are not sync'ed automatically (which forces us to do a review before pushing to the live server).

About the branches, we can probably removed them (except gh-pages, which is currently redirecting).

@anselmh
Copy link
Member Author

anselmh commented Dec 15, 2012

@marcoscaceres thanks for explaining. :)

@marcoscaceres
Copy link

No probs, sorry again about the confusion... it's been a crazy few weeks and I could have done better communicating the changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants