Refactor user theme CSS to be provided by a stylesheet endpoint #1035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1035 +/- ##
==========================================
- Coverage 95.71% 95.70% -0.01%
==========================================
Files 174 174
Lines 2704 2701 -3
==========================================
- Hits 2588 2585 -3
Misses 116 116 ☔ View full report in Codecov by Sentry. |
raccube
force-pushed
the
refactor/theme-css-endpoint
branch
from
ade0ac9
to
7caa767
Compare
nilsding
requested changes
Feb 2, 2023
raccube
force-pushed
the
refactor/theme-css-endpoint
branch
from
b130473
to
72d3c87
Compare
The `ETag` from `fresh_when` takes care of cache busting here.
This gets very aggressively cached so there isn't much of a point in making it respond to user themes as it doesn't always stay up to date.
Co-authored-by: Georg Gadinger <[email protected]>
Co-authored-by: Georg Gadinger <[email protected]>
raccube
force-pushed
the
refactor/theme-css-endpoint
branch
from
a69f040
to
92b0382
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.