Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spaghetti in backgrounds form, implement lazy loading #46

Open
unclamped opened this issue Sep 11, 2023 · 0 comments
Open

Spaghetti in backgrounds form, implement lazy loading #46

unclamped opened this issue Sep 11, 2023 · 0 comments

Comments

@unclamped
Copy link

While reviewing #12 and coming up with my own solution, I stumbled across file https://github.com/RiiConnect24/RiiTag-Next/blob/master/src/lib/constants/forms/backgrounds.js. It seems like the background selector in the RiiTag control panel is directly loading all backgrounds at once, from a predefined list. This could be improved in the future to recursively search the backgrounds folder, which would not only clean up the code a bit, but would also allow for seamless display of new backgrounds, such as custom ones as indicated in #12.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant