Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failed install requires manual cleanup, as rbenv does not detect if it's sucessfully installed. #132

Open
ronabop opened this issue Oct 29, 2015 · 0 comments

Comments

@ronabop
Copy link

ronabop commented Oct 29, 2015

https://github.com/ronabop/rbenv-cookbook/blob/master/libraries/chef_mixin_rbenv.rb

lines 59-61:

      def rbenv_installed?
        out = shell_out("ls #{rbenv_bin_path}/rbenv")
        out.exitstatus == 0
      end

Problem:
If the URL provided for the install is not available (for example, flaky internet, behind a corporate firewall), the first invocation of this cookbook creates an rbenv directory, and then fails to :sync. Subsequent invocations of the cookbook see that extant directory, and assume that rbenv has been installed, without needing to :sync, and fail.

PR #131 created.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant