EtherCIS- test Results- lab data values #8
Comments
|
This is due to a known issue apparently. Ethercis is returning the lab test results as a string containing the JSON structure, rather than the JSON itself |
|
thanks Rob |
|
The Marand fromat is Christian is proposing this light-weight version, which I think should be ok but needs testing |
|
There is also still a problem with some AQL formats not working on Ethercis. Christian is working on this. which should work for us. |
HeadingLab ResultsVersion:2.0.0 : 20-June-2017 TemplateID:
Summary AQL /query:To populate the list of items when the heading is selected. Alternative AQL using Resultset ObjectsDetail AQL /query:To populate the detailed view / edit when a single record within the heading is selected. Sample Composition(FLAT JSON) for POST/PUT /composition:To create or update a composition for a single item via the /composition Ehrscape API call. |
|
Using the alternative AQL in the above document should work on both CDRs. |
|
ok many thanks @freshehr |
|
Lab results seems to be now working on the dev machine - could someone check and confirm before I copy it to the demo machine? |
|
@freshehr Just tested this, there seems to be a change in the data returned.. 1 2 thanks |
|
It might just be that we have not included comments in the sample data.
I'll check
Ian
On Thu, 29 Jun 2017 at 17:50, Tony Shannon ***@***.***> wrote:
@freshehr <https://github.com/freshehr> Just tested this, there seems to
be a change in the data returned..
2 issues
1
the screenshot here shows the first row includes "Comment" as text.
[image: image]
<https://user-images.githubusercontent.com/939996/27699783-4c48e18c-5cf3-11e7-8b99-6fe379cacb8e.png>
2
yet the test result AQL doesnt seem to have a comment field, according to
Rob?
thanks
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#8 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABQ4RdFsR75qcVoh26HEZzzP0JRes83iks5sI9XkgaJpZM4N_1Ys>
.
--
Ian McNicoll
|
|
@ethercis - this seems to be a problem with Ethercis query resultset. The original composition is but the AQL result returns .. |
|
Looking further into it - the 'comment' data is valid - there is a comment associated with the labe result but I think the nesting is wrong, and the first lab result is missing. or in RAW JSON |
|
thanks @freshehr
Assume we're we waiting for further fix ?
Dont see comment in that JSON
Tony
…On 30 June 2017 at 09:34, Ian McNicoll ***@***.***> wrote:
Looking further into it - the 'comment' data is valid - there is a comment
associated with the labe result but I think the nesting is wrong, and the
first lab result is missing.
"laboratory_test_report/laboratory_test:0/laboratory_test_panel:0/laboratory_result:0/result_value/_name|value": "total protein measurement",
"laboratory_test_report/laboratory_test:0/laboratory_test_panel:0/laboratory_result:0/result_value|magnitude": 97,
"laboratory_test_report/laboratory_test:0/laboratory_test_panel:0/laboratory_result:0/result_value|unit": "g/l",
"laboratory_test_report/laboratory_test:0/laboratory_test_panel:0/laboratory_result:0/result_value/_normal_range/lower|unit": "g/l",
"laboratory_test_report/laboratory_test:0/laboratory_test_panel:0/laboratory_result:0/result_value/_normal_range/lower|magnitude": 60,
"laboratory_test_report/laboratory_test:0/laboratory_test_panel:0/laboratory_result:0/result_value/_normal_range/upper|unit": "g/l",
"laboratory_test_report/laboratory_test:0/laboratory_test_panel:0/laboratory_result:0/result_value/_normal_range/upper|magnitude": 80,
"laboratory_test_report/laboratory_test:0/laboratory_test_panel:0/laboratory_result:0/comment": "significantly raised level",
or in RAW JSON
"items": [
{
***@***.***": "CLUSTER",
"name": {
***@***.***": "DV_TEXT",
"value": "Laboratory result"
},
"archetype_node_id": "at0002",
"items": [
{
***@***.***": "ELEMENT",
"name": {
***@***.***": "DV_TEXT",
"value": "Comment"
},
"archetype_node_id": "at0003",
"value": {
***@***.***": "DV_TEXT",
"value": "singificantly raised level"
}
},
{
***@***.***": "ELEMENT",
"name": {
***@***.***": "DV_TEXT",
"value": "total protein measurement"
},
"archetype_node_id": "at0001",
"value": {
***@***.***": "DV_QUANTITY",
"magnitude": 97,
"units": "g/l"
}
}
]
},
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#8 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AA5X3GLCJchVygBh-CCTnAYV_v7GqNUHks5sJLMFgaJpZM4N_1Ys>
.
|
|
The problem is that a comment is appearing as the first object in the test panel array of objects, eg [{ { So the comment appears to relate to the group of tests within the test panel array. Previously we had a comment for each test within the test panel array. |
|
We could make a change at the UI level if the comment was consistently a
single comment and not a series of comments
Can we check how consistent that is /what API change would be needed to
serve a single comment to the UI?
…On 30 June 2017 at 15:28, robtweed ***@***.***> wrote:
The problem is that a comment is appearing as the first object in the test
panel array of objects, eg
[{
"name": {
"value": "Laboratory result"
},
"items": [{
"name": {
"value": "Comment"
},
"value": {
"value": "singificantly raised level"
},
***@***.*** <https://github.com/class>": "DV_TEXT",
"archetype_node_id": "at0003"
}],
"archetype_node_id": "at0002"
},
{
"name": {
"value": "Laboratory result #2
<#2>"
},
"items": [{
"name": {
"value": "albumin measurement, serum",
"defining_code": {
"codeString": "104485008",
"terminologyId": {
"name": "SNOMED-CT",
"value": "SNOMED-CT"
}
}
},
"value": {
"units": "g/l",
"accuracy": 0,
"magnitude": 67,
"precision": 0,
"normalRange": {
"interval": {
"lower": {
"units": "g/l",
"accuracy": 0,
"magnitude": 35,
"precision": 0,
"accuracyPercent": false,
"measurementService": {}
},
"upper": {
"units": "g/l",
"accuracy": 0,
"magnitude": 50,
"precision": 0,
"accuracyPercent": false,
"measurementService": {}
},
"lowerIncluded": true,
"upperIncluded": true
}
},
"accuracyPercent": false,
"measurementService": {}
},
***@***.*** <https://github.com/class>": "DV_QUANTITY",
"archetype_node_id": "at0001"
}],
"archetype_node_id": "at0002"
},...etc ]
So the comment appears to relate to the group of tests within the test
panel array. Previously we had a comment for each test within the test
panel array.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#8 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AA5X3L3OEOo-0Sfb5fBKXbpNbcSc1ac2ks5sJQYmgaJpZM4N_1Ys>
.
|
|
Well, if there's a single comment for the entire set of tests in the test panel, it would make more sense for the data returned from OpenEHR to have the comment separated out and not as one of the test panel objects (it always appears to be the first, though I'm not sure if that is definitely always the case). As it currently stands, it's tricky and messy for the middle tier mapping logic to treat one of the test panel array elements as a special case |
|
thanks Rob @freshehr Ian can you suggest an improvement to AQL re comment please? thanks |
|
Hi all. The problem here is not the AQL. I am pretty sure that the issue is that the 'raw' openEHR json coming back from Ethercis is not quite correct. @ The comment that is messing Rob up is actually associated with an individual result, not with the whole panel (though there can be a separate element for that, which we do use at times). The problem is that there is a chunk of json essentially missing. I did try to explain that in the other thread. This should be I will raise this again with Christian. There are a couple of other node name formatting issues that need tweaked as a well. |
|
Still not working I'm afraid Response: |
|
thanks Ian @freshehr |
|
It should be ok now - I tested it with the wrong query (which did not work) but the one that is being used currently in Ripple should work with both Ethercis and ThinkEhr. Just test the UI and see how we get on ... |
|
this looks to be working better now, with comments showing up properly
So I'm going to close this issue for now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Test lab results arent showing up in the detail that am expecting
See this related issue with screenshot
QEWD-Courier/Ripple-Qewd#38
The text was updated successfully, but these errors were encountered: