From 8a3ed0208613ee40c5ad2c5df303c3e418d21a7c Mon Sep 17 00:00:00 2001
From: Zachary Dremann <dremann@gmail.com>
Date: Sat, 13 Jan 2024 14:47:01 -0500
Subject: [PATCH] bugfix: Treemap.andnot would not include items with no
 container on rhs

---
 croaring/src/treemap/imp.rs | 15 ++++++++++++---
 croaring/src/treemap/ops.rs |  2 +-
 croaring/tests/lib.rs       | 12 ++++++++++++
 3 files changed, 25 insertions(+), 4 deletions(-)

diff --git a/croaring/src/treemap/imp.rs b/croaring/src/treemap/imp.rs
index 2db0c0a..05e9201 100644
--- a/croaring/src/treemap/imp.rs
+++ b/croaring/src/treemap/imp.rs
@@ -938,9 +938,18 @@ impl Treemap {
         let mut treemap = Treemap::new();
 
         for (key, bitmap) in &self.map {
-            if let Some(other_bitmap) = other.map.get(key) {
-                treemap.map.insert(*key, bitmap.andnot(other_bitmap));
-            }
+            let sub_bitmap = match other.map.get(key) {
+                Some(other_bitmap) => {
+                    let sub_bitmap = bitmap.andnot(other_bitmap);
+                    if sub_bitmap.is_empty() {
+                        continue;
+                    }
+                    sub_bitmap
+                }
+                // x.andnot(empty) == x
+                None => bitmap.clone(),
+            };
+            treemap.map.insert(*key, sub_bitmap);
         }
 
         treemap
diff --git a/croaring/src/treemap/ops.rs b/croaring/src/treemap/ops.rs
index eeedd1d..fc40048 100644
--- a/croaring/src/treemap/ops.rs
+++ b/croaring/src/treemap/ops.rs
@@ -472,7 +472,7 @@ impl<'a, 'b> Sub<&'a Treemap> for &'b Treemap {
     /// let mut treemap2 = Treemap::new();
     ///
     /// treemap2.add(25);
-    /// treemap1.add(u64::MAX);
+    /// treemap2.add(u64::MAX);
     ///
     /// let treemap3 = &treemap1 - &treemap2;
     ///
diff --git a/croaring/tests/lib.rs b/croaring/tests/lib.rs
index e9415ef..8294a92 100644
--- a/croaring/tests/lib.rs
+++ b/croaring/tests/lib.rs
@@ -168,6 +168,18 @@ fn test_treemap_deserialize_jvm() {
     }
 }
 
+#[test]
+fn test_treemap_max_andnot_empty() {
+    let single_max = Treemap::of(&[std::u64::MAX]);
+    let empty = Treemap::new();
+    let diff = single_max.andnot(&empty);
+    assert_eq!(diff, single_max);
+
+    let mut diff = single_max.clone();
+    diff.andnot_inplace(&empty);
+    assert_eq!(diff, single_max);
+}
+
 #[test]
 fn treemap_run_optimized() {
     let mut initial = Bitmap::new();