-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HTTP URLs opened from bookmarks should not be upgraded to HTTPS #17
Comments
Actually, the problem seems larger than the above scenario. On 0.4.3, if I do the following
then I am taken to "https://example.com" instead of "http://example.com". |
This is due to limitations of the extension API. For bookmarks I could try to detect whether a host name is bookmarked, and if if so, if there is at least one https-URL before redirecting. For the case of non-bookmarked domains, there is no side channel that I can use to determine whether the user typed "http://" or nothing. |
Sounds like a deep limitation :-(
Would this be enough grounds to reopen
https://bugzilla.mozilla.org/show_bug.cgi?id=1370388 ?
|
@cben That bug hasn't been closed yet. Though even if the linked bugs get resolved (i.e. we can distinguish typed navigations from non-typed navigations), then we still have the problem of detecting typed |
I'm starting to suspect that perhaps the best way to replicate the original behaviour would be to use the code from the original add-on to make a patch in gecko directly (behind an about:config pref). |
I think, at the least, this extension needs an option to allow opening http bookmarks with http. BTW, another useful extension to create would be one that goes through all bookmarks and sees if https is available for them. The only trick is that a screenshot would have to be taken of both the http and https versions to compare them. Some sites will load on https, but the content is broken. |
(this is off-topic)
This is something that can easily be done with an extension. But instead of using a screenshot, I would suggest to just confirm that the request succeeds successfully, or at most compare the response text. Comparing by screenshots is complicated and easily defeated when the result has dynamic content, e.g. embedded adverts. To get started with developing extensions, see https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions |
Here's another case that seems to be upgraded unnecessarily:
The text was updated successfully, but these errors were encountered: