Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve efficiency of is_smax and is_smin #19

Open
Robbepop opened this issue Mar 11, 2019 · 0 comments
Open

Improve efficiency of is_smax and is_smin #19

Robbepop opened this issue Mar 11, 2019 · 0 comments
Labels
A-bitvec Task operating on the stevia_bitvec crate in isolation. B-performance A task to improve performance (regression) of some part of the code base. D-easy A task that is considered to be simple to implement.

Comments

@Robbepop
Copy link
Owner

The current implementation of Bitvec::is_smax and Bitvec::is_smin is suboptimal because there is no native implementation for it in apint and we have to emulate the logic for it in stevia_bitvec. To improve this we could try implementing these (or similar) checks in apint since they might be reasonable to add there because of the already existing constructors unsigned_max_value etc.

@Robbepop Robbepop added B-enhancement An enhancement or new feature. D-easy A task that is considered to be simple to implement. A-bitvec Task operating on the stevia_bitvec crate in isolation. B-performance A task to improve performance (regression) of some part of the code base. and removed B-enhancement An enhancement or new feature. labels Mar 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-bitvec Task operating on the stevia_bitvec crate in isolation. B-performance A task to improve performance (regression) of some part of the code base. D-easy A task that is considered to be simple to implement.
Projects
None yet
Development

No branches or pull requests

1 participant