Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential issue of a bad actor hiding the order book #1439

Open
tmwclaxton opened this issue Sep 5, 2024 · 4 comments
Open

Potential issue of a bad actor hiding the order book #1439

tmwclaxton opened this issue Sep 5, 2024 · 4 comments

Comments

@tmwclaxton
Copy link

Describe the bug
An offer can be hidden from the order book by accepting it, but not paying the bond for a few minutes at a time. You could in theory then automate creating robots and accepting offers repeatedly so that only your orders get picked.

To Reproduce
Steps to reproduce the behavior:

  1. Create robots
  2. Accept offer - don't pay bond
  3. Log out - create new robot - observe offer is now gone

Expected behavior
Offers shouldn't disappear until their taker bond is paid; bonds should be refunded to people who weren't able to pay in time.

@iucrypto
Copy link

I sent funds, then the order was cancelled. I only received my bond back. I wasn't refunded my fiat, and didn't receive my lightning. Any advice on what to do? I still have the token.

@KoalaSat
Copy link
Member

I sent funds, then the order was cancelled. I only received my bond back. I wasn't refunded my fiat, and didn't receive my lightning. Any advice on what to do? I still have the token.

So you had an on going trade where you already sent fiat and the order was cancelled? How is that? Do you have screenshot or more details?

@g0lden3agle
Copy link

Won’t this introduce new complexities in if multiple robots are attempting to pay the bond simultaneously? Maybe a new “pending” state on the order book so only one user can still be paying the invoice but everyone can see that may become available again?

@femelo
Copy link
Contributor

femelo commented Nov 5, 2024

Won’t this introduce new complexities in if multiple robots are attempting to pay the bond simultaneously? Maybe a new “pending” state on the order book so only one user can still be paying the invoice but everyone can see that may become available again?

A solution would be to keep the order visible in the book but disable it to clicks with a visual feedback to indicate there is currently someone in process of locking the bond. That way, if other robot is interested in the order, it can watch the order state up until it becomes available again, which will probably elicit a watch list for users as a complementary feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants