Add over the moon coordinator #1591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
otmooon
reviewed
Nov 1, 2024
frontend/static/federation.json
Outdated
| @@ -142,6 +142,52 @@ | |||
| "mainnetNodesPubkeys": ["02c5b5972b05fba2cd2c2d9269a47bc478f73fae0f248a85cb1e5af60a07c1919d"], | |||
| "testnetNodesPubkeys": ["032b698c8143f293d138c0926594f11d119194ddedb513f63a944d14c094d0e54a"] | |||
| }, | |||
| "overthemoon": { | |||
otmooon
reviewed
Nov 1, 2024
frontend/static/federation.json
Outdated
| @@ -142,6 +142,52 @@ | |||
| "mainnetNodesPubkeys": ["02c5b5972b05fba2cd2c2d9269a47bc478f73fae0f248a85cb1e5af60a07c1919d"], | |||
| "testnetNodesPubkeys": ["032b698c8143f293d138c0926594f11d119194ddedb513f63a944d14c094d0e54a"] | |||
| }, | |||
| "overthemoon": { | |||
| "longAlias": "Over the moon", | |||
| "shortAlias": "overthemoon", | |||
There was a problem hiding this comment.
"shortAlias" can be changed to "moon" as well.
otmooon
suggested changes
Nov 1, 2024
|
Thanks for the review! These alias you see here are just used only on the tech side so it doesn't really affects or reach to the end user |
|
Hey, this coordinator won't be reachable for those using the self-hosted app. We need to add the correct nginx configs in https://github.com/RoboSats/robosats/tree/main/nodeapp/coordinators It's not too relevant. But I also favor |
Reckless-Satoshi
added a commit
that referenced
this pull request
Nov 2, 2024
* Add over the moon coordinator * Add Over the Moon to self-hosted backend * Add over the moon avatar --------- Co-authored-by: Reckless_Satoshi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #1586
Add over the moon coordinator
Checklist before merging
pip install pre-commit, thenpre-commit install. Pre-commit installs git hooks that automatically check the codebase. If pre-commit fails when you commit your changes, please fix the problems it points out.