Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add location to f2f federation #898

Closed
wants to merge 2 commits into from
Closed

Add location to f2f federation #898

wants to merge 2 commits into from

Conversation

KoalaSat
Copy link
Member

@KoalaSat KoalaSat commented Oct 17, 2023 •
edited
Loading

What does this PR do?

Fixes #897

This PR introduces/refactors/...

Checklist before merging

  • Install pre-commit and initialize it: pip install pre-commit, then pre-commit install. Pre-commit installs git hooks that automatically check the codebase. If pre-commit fails when you commit your changes, please fix the problems it points out.

@KoalaSat KoalaSat changed the base branch from main to the-federation-layer-v0.5.0 October 17, 2023 10:17
KoalaSat
KoalaSat commented Oct 17, 2023
View reviewed changes
frontend/src/components/Charts/helpers/OrderTooltip/index.tsx
@@ -0,0 +1,73 @@
import React, { useContext } from 'react';
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Previously there were some changes on the tooltip to make it work for Federation and I just include it here

@Reckless-Satoshi
Copy link
Collaborator

Reckless-Satoshi commented Oct 19, 2023 •
edited
Loading

Hey @KoalaSat , this PR is looking good thank you!

Before merging to the-federation-layer. Could you rebase the lastest from main and exclude from the PR all of the /frontend/static/locales/*.json files? It is best to avoid committing changes to the languages files while the federation branch is still under development to avoid nasty merge conflicts. We will collect all new phrases in the future when we merge the-federation-layer into main.

@KoalaSat
Copy link
Member Author

I created https://github.com/KoalaSat/robosats/tree/the-federation-layer-v0.5.1 wich is the federation branch rebased to main, so there is no necessity of this PR anymore

@KoalaSat KoalaSat closed this Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RoboRecap: current state of RoboSats development and TODOs by priority.
2 participants
@KoalaSat @Reckless-Satoshi