Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(fuselage): Update contextualbar z-index #1428

Merged
merged 4 commits into from
Nov 27, 2024
Merged

fix(fuselage): Update contextualbar z-index #1428

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
95ae913
fix: :bug: Update contextualbar z-index
rique223 Aug 21, 2024
37a3ad4
test: :white_check_mark: Update jest snapshots
rique223 Aug 22, 2024
ce77e1e
Create happy-houses-listen.md
rique223 Aug 22, 2024
7f8d8aa
Merge branch 'main' into fix/update-contextualbar-zindex
dougfabris Nov 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/happy-houses-listen.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@rocket.chat/fuselage": patch
---

Changes the `contextualbar` z-index to avoid UI glitches on pages where it needs to appear on top of the `Table`
2 changes: 1 addition & 1 deletion packages/fuselage/src/components/Contextualbar/Contextualbar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ const Contextualbar = forwardRef<HTMLElement, ContextualbarProps>(
position={position}
insetInlineEnd='none'
insetBlockStart='none'
zIndex={5}
zIndex={10}
{...props}
>
{children}
Expand Down
6 changes: 3 additions & 3 deletions packages/fuselage/src/components/Contextualbar/__snapshots__/Contextualbar.spec.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ exports[`[Contextualbar Rendering] renders Default without crashing 1`] = `
class="rcx-box rcx-box--full rcx-css-1ucnmmp"
>
<div
class="rcx-box rcx-box--full rcx-vertical-bar rcx-css-1pzjc7w"
class="rcx-box rcx-box--full rcx-vertical-bar rcx-css-dnnq8h"
>
<div
class="rcx-box rcx-box--full rcx-css-13kuqi8"
Expand Down Expand Up @@ -156,7 +156,7 @@ exports[`[Contextualbar Rendering] renders Empty without crashing 1`] = `
class="rcx-box rcx-box--full rcx-css-1ucnmmp"
>
<div
class="rcx-box rcx-box--full rcx-vertical-bar rcx-css-1pzjc7w"
class="rcx-box rcx-box--full rcx-vertical-bar rcx-css-dnnq8h"
>
<div
class="rcx-box rcx-box--full rcx-css-13kuqi8"
Expand Down Expand Up @@ -237,7 +237,7 @@ exports[`[Contextualbar Rendering] renders Skeleton without crashing 1`] = `
class="rcx-box rcx-box--full rcx-css-1ucnmmp"
>
<div
class="rcx-box rcx-box--full rcx-vertical-bar rcx-css-1pzjc7w"
class="rcx-box rcx-box--full rcx-vertical-bar rcx-css-dnnq8h"
>
<div
class="rcx-box rcx-box--full rcx-css-13kuqi8"
Expand Down
Loading