ENH: Create a dataset of pre-registered motors. #664
Labels
Enhancement
New feature or request, including adjustments in current codes
Good first issue
Good for newcomers
Motors
Every propulsion related issue or PR
Comments
Gui-FernandesBR
added
Enhancement
caioessouza
added a commit
to caioessouza/RocketPy
that referenced
this issue
Dec 2, 2024
I followed the recommendation "Download and save several .eng files in the repo so we can install it along with the rocketpy package itself". The website thrustcurve.org was very useful to search for some .eng files. I mainly focused in some of the main brands on the market: Cesaroni, Aero Tech, Animal Motors and Loki. And also focused on classes K to M, because this is the main range of total impulse that I'm used to seeing in rocketry. I tried to pick motors with a difference of about 300~600Ns in total impulse. Some more improvements than can also be made following this issue are expanding the dataset for whole SolidMotor objects, more than only thrust curves. I think this would be what the recommendation "Save .json files with all the information we may find available on internet" could mean. I decided to go for the simple for now, but having the thrust curves is a good first step to implementing that in the future, which I would totally be able to do!
4 tasks
Gui-FernandesBR
pushed a commit
to caioessouza/RocketPy
that referenced
this issue
Dec 8, 2024
I followed the recommendation "Download and save several .eng files in the repo so we can install it along with the rocketpy package itself". The website thrustcurve.org was very useful to search for some .eng files. I mainly focused in some of the main brands on the market: Cesaroni, Aero Tech, Animal Motors and Loki. And also focused on classes K to M, because this is the main range of total impulse that I'm used to seeing in rocketry. I tried to pick motors with a difference of about 300~600Ns in total impulse. Some more improvements than can also be made following this issue are expanding the dataset for whole SolidMotor objects, more than only thrust curves. I think this would be what the recommendation "Save .json files with all the information we may find available on internet" could mean. I decided to go for the simple for now, but having the thrust curves is a good first step to implementing that in the future, which I would totally be able to do! Update CHANGELOG.md MNT: git rename motor eng files in data folder
Gui-FernandesBR
added a commit
that referenced
this issue
Dec 8, 2024
* ENH: Create a dataset of pre-registered motors. See #664 I followed the recommendation "Download and save several .eng files in the repo so we can install it along with the rocketpy package itself". The website thrustcurve.org was very useful to search for some .eng files. I mainly focused in some of the main brands on the market: Cesaroni, Aero Tech, Animal Motors and Loki. And also focused on classes K to M, because this is the main range of total impulse that I'm used to seeing in rocketry. I tried to pick motors with a difference of about 300~600Ns in total impulse. Some more improvements than can also be made following this issue are expanding the dataset for whole SolidMotor objects, more than only thrust curves. I think this would be what the recommendation "Save .json files with all the information we may find available on internet" could mean. I decided to go for the simple for now, but having the thrust curves is a good first step to implementing that in the future, which I would totally be able to do! * Update CHANGELOG.md * MNT: git rename motor eng files in data folder * ENH: Create a dataset of pre-registered motors. See #664 I followed the recommendation "Download and save several .eng files in the repo so we can install it along with the rocketpy package itself". The website thrustcurve.org was very useful to search for some .eng files. I mainly focused in some of the main brands on the market: Cesaroni, Aero Tech, Animal Motors and Loki. And also focused on classes K to M, because this is the main range of total impulse that I'm used to seeing in rocketry. I tried to pick motors with a difference of about 300~600Ns in total impulse. Some more improvements than can also be made following this issue are expanding the dataset for whole SolidMotor objects, more than only thrust curves. I think this would be what the recommendation "Save .json files with all the information we may find available on internet" could mean. I decided to go for the simple for now, but having the thrust curves is a good first step to implementing that in the future, which I would totally be able to do! Update CHANGELOG.md MNT: git rename motor eng files in data folder --------- Co-authored-by: Gui-FernandesBR <[email protected]>
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Something OpenRocket does pretty well is to provide a wide range of available motors already on the software.
Maybe we could do something similar with .json files.
There are 2 options for us to accomplish this issue:
There's already na open PR solving this kind of issue in the first rocketpy hackathon (2020)
The text was updated successfully, but these errors were encountered: