Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

An error has occurred and the upper limit of the setting has been exceeded #147

Open
MuYuehe opened this issue Aug 15, 2023 · 9 comments
Open

Comments

@MuYuehe
Copy link

MuYuehe commented Aug 15, 2023

When I try to stack two 10000 [Bag of Gold], sometimes I get a 20000 [Bag of Gold].
When I throw out this 20000 [Bag of Gold], it is still a 20000 [Bag of Gold].
When I picked up this 20000 [Bag of Gold], I got two 10000 [Bag of Gold].
I think it's a misnomer.
I don't know if [Bag of Gold] supports stacking, but I can stack it together.
https://pastebin.com/ceZRNcir
image

@Rocologo
Copy link
Owner

It's a bug. The should not stack.

@Rocologo
Copy link
Owner

The bag size can be set in config and like physical money you can only have a limited number of coins in a bag. And only one bag in a slot. This is the idea.

@MuYuehe
Copy link
Author

MuYuehe commented Aug 15, 2023

The stacking problem I found was related to another plugin.
But I do get a bag that exceeds the limit

@Rocologo
Copy link
Owner

Rocologo commented Aug 16, 2023

Are you able reproduce the stacking? Do you know how to do it every time?

@MuYuehe
Copy link
Author

MuYuehe commented Aug 16, 2023

Yes, I can reproduce stacking.
As I said above, it is because of another plugin: ChestSort.
When I put two [Bag of Gold] in the backpack, and then use [ChestSort] to sort the backpack, I get a stacked [Bag of Gold].
image
This is the reply I got on their channel.
I don't think stacking is a huge issue.
More importantly, [Bag of Gold] will exceed the upper limit set.
Just need to operate:

  1. First get two [Bag of Gold] that have reached the upper limit.
  2. Then try stacking one with the other.
  3. There is a certain probability that you will get a [Bag of Gold] that exceeds the upper limit.

@Rocologo
Copy link
Owner

Okay. This is because ChestSort see the bagofgold item as a head, which can be stacked. The only solution to this is to ask the Dev of ChestSort to Hook into CustomitemsLib so he can check if the item (head) is a Bagofgold. If he is willing to do this, I will help help him with the test to see it the item is a BagOfGold.

@Rocologo
Copy link
Owner

Im at work now, so I cant run Minecraft to check the other problem.

@Rocologo
Copy link
Owner

Rocologo commented Aug 17, 2023

I have worked on "COLLECT_ALL_TO_CURSOR" and "PLACE_SOME" / "PLACE_ALL" in latest build

https://jenkins.lindegaard.one/job/CustomItemsLib/

But I am pretty sure that I have not found all problems. :-|

I need help with the testing.

@MuYuehe
Copy link
Author

MuYuehe commented Aug 17, 2023

ok, i will test tomorrow, it's 23 o'clock now, good night

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants